Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add external cmd selector package #78

Merged
merged 17 commits into from
Dec 3, 2021
Merged

feat: add external cmd selector package #78

merged 17 commits into from
Dec 3, 2021

Commits on Dec 1, 2021

  1. Porting remote cmd selector (autowarefoundation#1286) 

    * Feature/add remote cmd selector (autowarefoundation#1179)

* Add in/out args of remote_cmd_converter.launch

Signed-off-by: Kenji Miyake <[email protected]>

* Change remote input topic of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Add msgs for remote_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Add remote_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <[email protected]>

* Remove VehicleCommand support in autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix porting miss

Signed-off-by: Kenji Miyake <[email protected]>

* fix missing function

* modify xml format

* fix include guard

* add callback group

* modify remap name

* Revert "modify remap name"

This reverts commit 169cc8d28442825b1d61b0439b9892c913304527.

* change topic name

* use rclcpp_component

* Remove autoware_debug_msgs from autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Change default mode of autoware_joy_controller

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
    @KeisukeShima @kenji-miyake @taikitanaka3
    3 people authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    20aef27 View commit details
    Browse the repository at this point in the history

  2. fix ament (autowarefoundation#1307)

    @taikitanaka3
    taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    70dba6c View commit details
    Browse the repository at this point in the history

  3. Ros2/create/external commands (autowarefoundation#1299) 

    * add remote message

* add remote commands

* fix topic

* remove unnecessary topic

* remove unused topic

* add external cmd instead

* ToExternalComd

* fix topic in joy con
    @taikitanaka3
    taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    c80d489 View commit details
    Browse the repository at this point in the history

  4. Fix -Wunused-parameter (autowarefoundation#1836) 

    * Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>
    @kenji-miyake @h-ohta @taikitanaka3
    2 people authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3138e55 View commit details
    Browse the repository at this point in the history

  5. suppress warnings for control packages (autowarefoundation#1892) 

    * add Werror

* add maybe unused
    @h-ohta @taikitanaka3
    h-ohta authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3ccb5ec View commit details
    Browse the repository at this point in the history

  6. Add autoware api (autowarefoundation#1979)

    @isamu-takagi @taikitanaka3
    isamu-takagi authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    2ffe401 View commit details
    Browse the repository at this point in the history

  7. Move launch file of external_cmd_selector (autowarefoundation#2017) 

    * Move launch file of external_cmd_selector

Signed-off-by: Takagi, Isamu <[email protected]>

* Add copyright

Signed-off-by: Takagi, Isamu <[email protected]>

* Use DeclareLaunchArgument

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix external command api name

Signed-off-by: Takagi, Isamu <[email protected]>

* Move common parameters

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix format

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix format

Signed-off-by: Takagi, Isamu <[email protected]>
    @isamu-takagi @taikitanaka3
    isamu-takagi authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    43dba81 View commit details
    Browse the repository at this point in the history

  8. Use EmergencyState instead of deprecated EmergencyMode (autowarefound… 

    …ation#2030)

* Use EmergencyState instead of deprecated EmergencyMode

Signed-off-by: Kenji Miyake <[email protected]>

* Use stamped type

Signed-off-by: Kenji Miyake <[email protected]>
    @kenji-miyake @taikitanaka3
    kenji-miyake authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8ee4dd6 View commit details
    Browse the repository at this point in the history

  9. add sort-package-xml hook in pre-commit (autowarefoundation#1881) 

    * add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit
    @KeisukeShima @taikitanaka3
    KeisukeShima authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    ba5df4f View commit details
    Browse the repository at this point in the history

  10. Improve diagnostic tree for future extensions (autowarefoundation#2153) 

    * change resource monitoring group

* implement diagnostic tree proposal

* rename v2x param file

* add v2x to launch

* add dummy analyzer to avoid format error

* modify external control

* rename vehicle_ecu_errors

* fixup

* remove num_items

* fix error

* add heartbeat to external command selector

* Restore sensing/node_alive_monitoring

* Update system/autoware_error_monitor/config/diagnostic_aggregator/sensing.param.yaml

Co-authored-by: Kenji Miyake <[email protected]>

* add sensor_kit arg for diagnostic_agg

* change sensor_kit's default value

* add _ prefix to hide parameter file

* delete dummy parameter

* change to use update_functions

* add extra_agg_config_file_vehicle

* change initializer

* remove line

* Update system/autoware_error_monitor/config/diagnostic_aggregator/system.param.yaml

Co-authored-by: Kenji Miyake <[email protected]>

* change hearbeat diag

* add clock group

* update sensing diag

* Remove discard and v2x

Signed-off-by: Kenji Miyake <[email protected]>

* Fix heartbeat name

Signed-off-by: Kenji Miyake <[email protected]>

* Add remote_external_control

Signed-off-by: Kenji Miyake <[email protected]>

* Add external_control

Signed-off-by: Kenji Miyake <[email protected]>

* Rename remote_control to external_control

Signed-off-by: Kenji Miyake <[email protected]>

* Rename command_gate to control_command_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Simplify resource monitoring

Signed-off-by: Kenji Miyake <[email protected]>

* Remove sensing from autoware_error_monitor.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Remove trajectory_deviation

Signed-off-by: Kenji Miyake <[email protected]>

* Remove vehicle specific settings

Signed-off-by: Kenji Miyake <[email protected]>

* Add blank lines

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore matching_score error

Signed-off-by: Kenji Miyake <[email protected]>

* Remove debug_data_logger

Signed-off-by: Kenji Miyake <[email protected]>

* Add trajectory_validation

Signed-off-by: Kenji Miyake <[email protected]>

* Specify children for performance_monitoring

Signed-off-by: Kenji Miyake <[email protected]>

* Comment out route_validation

Signed-off-by: Kenji Miyake <[email protected]>

* Revert "Remove trajectory_deviation"

This reverts commit 199132f1a6c7083440f0ef9a956b0663d45f4531.

* Remove control_command_topic_status

Signed-off-by: Kenji Miyake <[email protected]>

* Disable some diagnostics for planning simulator

Signed-off-by: Kenji Miyake <[email protected]>

* Add TODO comment

Signed-off-by: Kenji Miyake <[email protected]>

* Enable /autoware/vehicle/node_alive_monitoring in planning simulator

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
    @KeisukeShima @kenji-miyake @taikitanaka3
    3 people authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3d3d8d0 View commit details
    Browse the repository at this point in the history

  11. Fix missing dependency of external_cmd_selector (autowarefoundation#2324 

    )

Signed-off-by: Kenji Miyake <[email protected]>
    @kenji-miyake @taikitanaka3
    kenji-miyake authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8242a24 View commit details
    Browse the repository at this point in the history

  12. Change formatter to clang-format and black (autowarefoundation#2332) 

    * Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>
    @kenji-miyake @taikitanaka3
    kenji-miyake authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3d93e9b View commit details
    Browse the repository at this point in the history

  13. Add COLCON_IGNORE (autowarefoundation#500) 

    Signed-off-by: Kenji Miyake <[email protected]>
    @kenji-miyake @taikitanaka3
    kenji-miyake authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    ec0ff66 View commit details
    Browse the repository at this point in the history

  14. port part of external_cmd_selector (autowarefoundation#497) 

    * port part of external_cmd_selector

Signed-off-by: Kosuke Murakami <[email protected]>

* add convert function

Signed-off-by: kosuke murakami <[email protected]>

* port signal

Signed-off-by: kosuke murakami <[email protected]>

* Update control/external_cmd_selector/include/external_cmd_selector/external_cmd_selector_node.hpp

Co-authored-by: tkimura4 <[email protected]>
    @k0suke-murakami @tkimura4 @taikitanaka3
    2 people authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    4ff2637 View commit details
    Browse the repository at this point in the history

  15. Fix publisher in external_cmd_selector (autowarefoundation#676)

    @rej55 @taikitanaka3
    rej55 authored and taikitanaka3 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    42afb59 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'tier4/proposal' into 1-add-external-cmd-selector

    @taikitanaka3
    taikitanaka3 authored Dec 1, 2021
    Configuration menu
    Copy the full SHA
    bdfab5a View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Merge branch 'tier4/proposal' into 1-add-external-cmd-selector

    @1222-takeshi
    1222-takeshi authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    59989a4 View commit details
    Browse the repository at this point in the history