-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify Rolling support #854
Conversation
Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake thanks for simplifying this code. Regarding these blocks: #ifdef ROS_DISTRO_GALACTIC
#include <tf2_geometry_msgs/tf2_geometry_msgs.h>
#else
#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp> do it the other way around, because otherwise we'd have to add an #ifdef ROS_DISTRO_FOXY
#include <tf2_geometry_msgs/tf2_geometry_msgs.h>
#else
#include <tf2_geometry_msgs/tf2_geometry_msgs.hpp> a different option is to keep the code as is, but instead of adding |
@kenji-miyake forget what I just wrote, for some reason I thought we supported Foxy and that the special case for Galaxy was the same as for Rolling and Humble. |
@kenji-miyake is it documented anywhere that we no longer support Foxy? Otherwise this code would fail when compiling on Foxy. |
@esteve Although there is no background written, the supported distros are here. |
Foxy has several problems and isn't supported anymore. Related discussions of Autoware.Auto: |
After Humble, I think we should support LTS distros at least until the next LTS is released. (If there is no special reason like Foxy.) And regarding Humble, we have to plan a migration strategy. |
@kenji-miyake thanks for the links, in that case the changes look good to me. |
Signed-off-by: Kenji Miyake <[email protected]> Signed-off-by: kminoda <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
…date_start_goal_planner_v0.10.1_2 Feat/sugahara/update start goal planner v0.10.1 2
Description
As a follow-up of #849, I replaced the custom-defined macros with
ROS_DISTRO
macros.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.