feat(occupancy_grid_based_outlier_fillter): add config file to autoware_launch #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <[email protected]>
4 tasks
kminoda
approved these changes
Aug 26, 2024
badai-nguyen
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
The PR is LGTM.
IMO, It should be better to wait untill autowarefoundation/autoware.universe#6745 is ready to merge?
|
kyoichi-sugahara
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 27, 2024
…re_launch (autowarefoundation#1137) * feat: add config file Signed-off-by: yoshiri <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related autowarefoundation/autoware.universe#6745, add config param to autoware_launch.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.