-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception/occupancy_grid_map_outlier_filter): rework parameters #6745
refactor(perception/occupancy_grid_map_outlier_filter): rework parameters #6745
Conversation
Sorry for super-late reply. 🙇 |
Any updates from rosbag execution problem ? @YoshiRi |
cde7a94
to
1fcd053
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Ready for review @YoshiRi |
...on/autoware_occupancy_grid_map_outlier_filter/src/occupancy_grid_map_outlier_filter_node.cpp
Outdated
Show resolved
Hide resolved
1fcd053
to
0719524
Compare
@oguzkaganozt cc: @Shin-kyoto @badai-nguyen This package change seems to be okay, but this will cause trouble with I think we need following approach:
I will do 1. first, and want to merge this PR after 2. is solved. ( to prevent autoware crush ) |
@badai-nguyen |
5253385
to
e1a91fe
Compare
Hi any updates on this ? @YoshiRi @badai-nguyen |
Hi any updates on this ? @badai-nguyen @YoshiRi |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6745 +/- ##
==========================================
- Coverage 24.15% 24.15% -0.01%
==========================================
Files 1400 1400
Lines 102252 102261 +9
Branches 38758 38761 +3
==========================================
Hits 24697 24697
- Misses 75046 75055 +9
Partials 2509 2509
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f2bf929
to
aac3fa7
Compare
I think we need to change related launcher: But sorry, I had not tested yet. autoware_launch need to be updated before testing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package change seems to be okay, but this will cause trouble with
occupancy_grid_based_outlier_filter
node declaration inground_segmentation.launch.py
.
I think we need following approach:
-
- add your config file to
autoware_launch
- add your config file to
-
- modify
ground_segmentation.launch.py
to look for the config file
I will do 1. first, and want to merge this PR after 2. is solved. ( to prevent autoware crush )
- modify
@oguzkaganozt Thank you for your contribution,
I think @YoshiRi already left a comment as above, could you confirm and solve 2 as his suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed launch problem in a6f83ef and f3d008d.
Tested with my local PC.
@Shin-kyoto @badai-nguyen
Could you update the status?
Signed-off-by: oguzkaganozt <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: oguzkaganozt <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
0d13734
to
70195b3
Compare
…ters (autowarefoundation#6745) * add param and schema file, edit readme Signed-off-by: oguzkaganozt <[email protected]> * . Signed-off-by: Oguz Ozturk <[email protected]> * correct linter errors Signed-off-by: oguzkaganozt <[email protected]> --------- Signed-off-by: oguzkaganozt <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]>
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.