Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add param for configurable lateral_distance #140

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Dec 22, 2022

Signed-off-by: beyza [email protected]

Description

This PR adds parameters for using predicted objects to autoware_launch/config

Related Link

autowarefoundation/autoware.universe#2290

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya self-assigned this Dec 22, 2022
@beyzanurkaya beyzanurkaya force-pushed the feat/add-param-configurable-lateral-distance branch from 7f8234d to 85df68a Compare January 17, 2023 10:26
@beyzanurkaya beyzanurkaya changed the title feat(autoware_launch):add param for configurable lateral_distance feat(autoware_launch): add param for configurable lateral_distance Jan 19, 2023
@beyzanurkaya beyzanurkaya force-pushed the feat/add-param-configurable-lateral-distance branch from 6fe1e15 to 51fc47f Compare February 1, 2023 07:25
@satoshi-ota satoshi-ota self-requested a review February 9, 2023 23:29
@beyzanurkaya beyzanurkaya force-pushed the feat/add-param-configurable-lateral-distance branch from 2236818 to 5f7b901 Compare February 10, 2023 15:59
@beyzanurkaya beyzanurkaya force-pushed the feat/add-param-configurable-lateral-distance branch from 5f7b901 to 45ec32e Compare February 12, 2023 11:59
@beyzanurkaya beyzanurkaya force-pushed the feat/add-param-configurable-lateral-distance branch from 45ec32e to 14fa4a1 Compare February 12, 2023 12:03
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beyzanurkaya beyzanurkaya merged commit 489cfc7 into autowarefoundation:main Feb 14, 2023
@beyzanurkaya beyzanurkaya deleted the feat/add-param-configurable-lateral-distance branch June 9, 2023 08:06
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
* ci: add build CI

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add files for Ansible Galaxy

Signed-off-by: Kenji Miyake <[email protected]>

* feat: copy ansible files from tier4's proposal

Remove cache_valid_time

Signed-off-by: Kenji Miyake <[email protected]>

v0.4.0

Signed-off-by: mitsudome-r <[email protected]>

copy setup

Signed-off-by: Takamasa Horibe <[email protected]>

add ros2 ansible roles

Signed-off-by: Takamasa Horibe <[email protected]>

ansible add ubuntu20 setup

Signed-off-by: Takamasa Horibe <[email protected]>

ansible fix pacmod

Signed-off-by: Takamasa Horibe <[email protected]>

temp disable cuda & tensorrt

Signed-off-by: Takamasa Horibe <[email protected]>

ansible fix kvaser library repo

Signed-off-by: Takamasa Horibe <[email protected]>

temporally comment out for unused modules

Signed-off-by: Takamasa Horibe <[email protected]>

remove unused codes

Signed-off-by: Takamasa Horibe <[email protected]>

Install osqp only once (autowarefoundation#95)

* update readme and fix osqp_vendor tag

* Remove ansible osqp role

fix: ansbile role

Closes autowarefoundation#140

add ansible for cuda 11.1 & tensorrt 7.2.1 & cudnn 8.0.5

Signed-off-by: Takamasa Horibe <[email protected]>

add script for install livox sdk

Signed-off-by: kosuke murakami <[email protected]>

add ansible sdk task

Signed-off-by: kosuke murakami <[email protected]>

Use Livox vendor package (autowarefoundation#156)

* Use Livox vendor package

* Removed Livox SDK from ansible

* Use upstream Livox ROS2 driver

Install kvaser library

Signed-off-by: wep21 <[email protected]>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

Install kvaser library from origin

Signed-off-by: wep21 <[email protected]>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

install vcstool and do vcs import in ansible setup (autowarefoundation#170)

Update documents and fix typos

* update install instructions
* remove redundant statements
* fix typos

Separate Ansible tasks related to vcs import to new role (autowarefoundation#180)

* Separate Ansible tasks related to vcs import to new role

* Move the Ansible task to install vcstool to the ROS2 role

Add rmw-cyclonedds-cpp to ansible (autowarefoundation#67)

* Add rmw-cyclonedds-cpp to ansible

Signed-off-by: Kenji Miyake <[email protected]>

* Add settings to .bashrc

Signed-off-by: Kenji Miyake <[email protected]>

Fix setup script typos (autowarefoundation#202) (autowarefoundation#73)

Signed-off-by: Lalith Vipulananthan <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

Revive pacmod role (autowarefoundation#103)

* Revert "Install kvaser library from origin"

This reverts commit 3859fffd60164febbaacc2f68b045d3b0d07f3d6.

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ROS role

Signed-off-by: Kenji Miyake <[email protected]>

install pip before rosdep (autowarefoundation#72)

Fix: Update GPG key download task for ROS2 (autowarefoundation#125)

* Fix: Update GPG key download task for ROS2

* Fix: Update comments, source list

Add pre-commit CI (autowarefoundation#167)

* Add pre-commit CI

Signed-off-by: Kenji Miyake <[email protected]>

* Add .prettierrc.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore some markdownlint rules

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

Move to ROS2 Galactic (autowarefoundation#107)

* Fix rosdistro in ansible

Fix rosdistro other than autoware in ansible (autowarefoundation#146)

* Use upstream grid_map

Signed-off-by: Kenji Miyake <[email protected]>

* Remove rosbag2

Signed-off-by: kosuke55 <[email protected]>

* Change position of ecu_system_setup section

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing_packages in galactic

Signed-off-by: Kenji Miyake <[email protected]>

* Add ros2/rosbag2 galactic to repos

Signed-off-by: kosuke55 <[email protected]>

* Purge installed rosbag2 to build it from source

Signed-off-by: kosuke55 <[email protected]>

* Add TODO comment to repos

Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: kosuke55 <[email protected]>

Install ros-galactic-ros2cli-common-extensions in ansible (autowarefoundation#183)

* Signed-off-by: kosuke55 <[email protected]>

Install ros-galactic-ros2cli-common-extensions in ansible

Signed-off-by: kosuke55 <[email protected]>

* Add descriptions of rosbag2 purge

Use apt installed rosbag2 (autowarefoundation#189)

Signed-off-by: kosuke55 <[email protected]>

Remove vcs import in ansible (autowarefoundation#198)

* Remove vcs import in ansible

Signed-off-by: kosuke55 <[email protected]>

* Update installation steps

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

fix gdown install command (autowarefoundation#214)

Simplify ansible files (autowarefoundation#122)

* Simplify ansible files

Signed-off-by: Kenji Miyake <[email protected]>

* Add build-pr.yml

Signed-off-by: Kenji Miyake <[email protected]>

add libtorch (autowarefoundation#131) (autowarefoundation#191)

* add libtorch (autowarefoundation#131)

* add libtorch

* update libtorch 1.6.0 -> 1.8.1

* libtorch for CUDA 11.1

* use the same command

* libtorch 1.8.1 -> 1.6.0

* add LibTorch for CUDA 11.1

* change install order

* Deprecate 18.04 support for libtorch

Signed-off-by: wep21 <[email protected]>

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yusuke Muramatsu <[email protected]>

fix libtorch install (autowarefoundation#196)

Feature/remove pacmod3 (autowarefoundation#349)

* remove pacmod3

* Remove kvaser_interface from repos

Signed-off-by: wep21 <[email protected]>

* Fix ansible

Signed-off-by: wep21 <[email protected]>

* Fix vcs import action

Signed-off-by: wep21 <[email protected]>

* Run pre-commit

Signed-off-by: wep21 <[email protected]>

Co-authored-by: wep21 <[email protected]>

add go dependency for pre-commit (autowarefoundation#388)

* add go dependency by snap install --classic

* move install-go from autoware/ to pre-commit/

* update playbook.yml

* use apt without snap to install golang

* chore: clean up files

Signed-off-by: Kenji Miyake <[email protected]>

* fix: specify pip3 executable to prevent pipx to be used

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add docker role

Signed-off-by: Kenji Miyake <[email protected]>

* fix: use ansible_user_id instead of ansible_env.USER

root user doesn't have ansible_env.USER.

Signed-off-by: Kenji Miyake <[email protected]>

* chore: fix verbose option

Signed-off-by: Kenji Miyake <[email protected]>

* feat: remove libtorch

Signed-off-by: Kenji Miyake <[email protected]>

* feat: add --no-nvidia option

Signed-off-by: Kenji Miyake <[email protected]>

* style: rename ansible_options to ansible_args

Signed-off-by: Kenji Miyake <[email protected]>

* feat: update CUDA versions

Signed-off-by: Kenji Miyake <[email protected]>

* chore: fix scripts around sudo

Signed-off-by: Kenji Miyake <[email protected]>

* feat: support arm64-sbsa in CUDA role

Signed-off-by: Kenji Miyake <[email protected]>

* ci: add ARM build

Signed-off-by: Kenji Miyake <[email protected]>

* chore: comment out simulator repositories

autowarefoundation/autoware#21
Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants