-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(occlusion_spot): occlusion spot parameter disable as default #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Occlusion Spot is still unstable and has many issues in the real world. It is reasonable to disable it by default until the problems are fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zulfaqar-azmi-t4 |
ce8eae3
to
0482221
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
0482221
to
8a78adc
Compare
* feat: define lat_controller_param_path * feat: change for trajectory_follower params * add args for lat_controller_param_path
* update parameter (autowarefoundation#169) * Port pure pursuit (autowarefoundation#166) * Fix control.launch.py * Apply pre-commit * Fix control.launch.py * Change debug topic name in rviz setting * fix typo in localization util.launch.py (autowarefoundation#168) * Feature/add covarinace param (autowarefoundation#170) * add covariance param * add description * remove unused param (autowarefoundation#172) * Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (autowarefoundation#174) * Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0 Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update spell_check_pr.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> * fix: fix hdd_monitor param (autowarefoundation#173) * add rosbridge launch (autowarefoundation#175) * add rosbridge launch * fix TODO document add link to pull request Co-authored-by: Kenji Miyake <[email protected]> * fix double-byte character Co-authored-by: Kenji Miyake <[email protected]> * chore: sync files (autowarefoundation#177) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * ci: update CI settings (autowarefoundation#176) * ci(pre-commit): update .pre-commit-config.yaml Signed-off-by: Kenji Miyake <[email protected]> * ci: add sync-files.yaml Signed-off-by: Kenji Miyake <[email protected]> * chore: remove old workflows Signed-off-by: Kenji Miyake <[email protected]> * ci(sync-upstream): update sync-upstream.yaml Signed-off-by: Kenji Miyake <[email protected]> * ci(pre-commit): autofix * style: fix for yamllint Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: minor update CI settings (autowarefoundation#179) Signed-off-by: Kenji Miyake <[email protected]> * [pre-commit.ci] pre-commit autoupdate (autowarefoundation#178) updates: - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0) - [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1) - [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1) - [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> * chore: fix CI settings (autowarefoundation#182) Signed-off-by: Kenji Miyake <[email protected]> * chore: sync files (autowarefoundation#180) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * chore: sync files (autowarefoundation#184) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: add paricle param (autowarefoundation#181) Signed-off-by: YamatoAndo <[email protected]> * chore: sync files (autowarefoundation#185) * chore: sync files Signed-off-by: GitHub <[email protected]> * Update sync-files.yaml Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync files (autowarefoundation#186) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * chore: sync system config (autowarefoundation#187) Signed-off-by: wep21 <[email protected]> * chore: sync files (autowarefoundation#189) Signed-off-by: GitHub <[email protected]> Co-authored-by: wep21 <[email protected]> * chore: replace system config in system launch (autowarefoundation#188) Signed-off-by: wep21 <[email protected]> * feat: adds additional configuration flags for behavior_path_planner (autowarefoundation#171) * feat: adds additional configuration flags for behavior_path_planner The additional configuration is used to allows avoidance over lane with same and different direction, as well as allows safety margin between linestring and ego. This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496 port. Related PR: autowarefoundation/autoware.universe#285 autowarefoundation/autoware.universe#287 Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Change lateral_collision_margion to 1.0 to reflect changes. The decision to change the parameter value to 1.0 is made after performing drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting between planning control team on 3rd of February 2022. Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix: slightly increase the safety buffer. This increases the shift length to 1.7 + 0.5 * vehicle width. The decision to increase is based on the discussion between planning team and also the advice from the FI team. Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * feat(behavior_velocity): add path marker visualization (autowarefoundation#190) Signed-off-by: tanaka3 <[email protected]> * chore: sync files (autowarefoundation#193) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * chore: sync files (autowarefoundation#194) * chore: sync files Signed-off-by: GitHub <[email protected]> * chore: update workflow files name Signed-off-by: h-ohta <[email protected]> Co-authored-by: h-ohta <[email protected]> Co-authored-by: h-ohta <[email protected]> * chore: sync files (autowarefoundation#195) Signed-off-by: GitHub <[email protected]> Co-authored-by: h-ohta <[email protected]> * feat: lateral controller param (autowarefoundation#191) * feat: define lat_controller_param_path * feat: change for trajectory_follower params * add args for lat_controller_param_path * chore: fix wrong essential param to optional (autowarefoundation#197) * fix wrong param line * move pointcloud_container_name param to optional * fix: typo extra `>` (autowarefoundation#199) * Chore arrange perception rviz topics (autowarefoundation#196) * feat(autoware_launch): add occupancy grid vizualization Signed-off-by: tanaka3 <[email protected]> * feat(autoware_launch): add object recognition namespace to rviz Signed-off-by: tanaka3 <[email protected]> * fix: delete unused in control_launch (autowarefoundation#200) * fix: delete unused in control.launch.py * fix: delete velocity_controller.param.yaml * feat: add system_monitor parameters in sync-files (autowarefoundation#201) * chore: sync files (autowarefoundation#202) Signed-off-by: GitHub <[email protected]> Co-authored-by: h-ohta <[email protected]> * chore: sync files (autowarefoundation#203) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * chore: update settings of sync-files (autowarefoundation#204) Signed-off-by: Kenji Miyake <[email protected]> * feat(control_launch): remove unnecessary params (autowarefoundation#206) Signed-off-by: Takayuki Murooka <[email protected]> * chore: sync files (autowarefoundation#208) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat(atutoware.rviz): disable selectable for pointcloud visualization (autowarefoundation#207) Signed-off-by: YamatoAndo <[email protected]> * chore: sync files (autowarefoundation#212) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * delete vehicle parameters in longitudinal_controller.param.yaml * apply pre-commit * remove unused file * update sync-param-files.yaml * disable local_external_control in system_error_montitor_psim Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: YamatoAndo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: yabuta <[email protected]> Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: wep21 <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: h-ohta <[email protected]> Co-authored-by: h-ohta <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
chore: sync awf/autoware_launch
Signed-off-by: Muhammad Zulfaqar Azmi [email protected]
Description
This PR aims to disable occlusion spot module by default.
The occlusion spots feature was introduced to decelerate anticipating people jumping out from behind nearby vehicles, but it causes unnecessary slowing down in multi-lane driving. This design issue has yet to be fixed.
Due to the issue, currently, some functional test are facing complication. To reduce this occurrence, occlusion spot is disabled.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.