refactor(planning_launch): remove duplicated lane change parameter #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <[email protected]>
4 tasks
This was referenced Apr 26, 2023
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Apr 26, 2023
* fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]>
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Apr 26, 2023
* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * add calibration status launcher to external_api_adaptor Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * pull the latest tier4/universe Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> * fixed unnecessary change. Signed-off-by: TakumiKozaka-T4 <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]>
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Apr 26, 2023
* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <[email protected]> * fix(perception_launch): fix vehicle param in perception launch Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: k-obitsu <[email protected]>
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Apr 26, 2023
* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <[email protected]> * rename Signed-off-by: Kenji Miyake <[email protected]> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <[email protected]> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <[email protected]> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <[email protected]> * change line Signed-off-by: tkhmy <[email protected]> * change back to alphabetical order Signed-off-by: tkhmy <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <[email protected]> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <[email protected]> * add localization score relay node Signed-off-by: TakumiKozaka-T4 <[email protected]> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <[email protected]> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: k-obitsu <[email protected]>
This was referenced Apr 27, 2023
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
May 7, 2023
Signed-off-by: Takeshi Miura <[email protected]> Signed-off-by: Takeshi Miura <[email protected]>
rej55
pushed a commit
to rej55/autoware_launch
that referenced
this pull request
Jun 12, 2023
* chore: sync files (autowarefoundation#327) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * refactor: virtual wall rviz config (autowarefoundation#326) Signed-off-by: Takamasa Horibe <[email protected]> * feat(rviz_plugin): adaptive scaling for display size (autowarefoundation#329) Signed-off-by: Takamasa Horibe <[email protected]> * fix: support context dict key for humble (autowarefoundation#328) * fix: support context dict key for humble Signed-off-by: wep21 <[email protected]> * add todo comment Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> * fix: modify type of global parameter (autowarefoundation#333) Signed-off-by: wep21 <[email protected]> * chore: sync files (autowarefoundation#335) Signed-off-by: GitHub <[email protected]> Co-authored-by: kenji-miyake <[email protected]> * feat: use multithread for traffic light container as default (autowarefoundation#336) Signed-off-by: tomoya.kimura <[email protected]> * fix(localization_launch): fix input topic name (autowarefoundation#338) * feat(behavior_velocity): add run out module (autowarefoundation#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <[email protected]> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <[email protected]> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]> Co-authored-by: Yamato Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 12, 2023
…ation#326) (autowarefoundation#328) fix launch parameter of centerpoint model path
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Kenji Miyake <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Mar 1, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicated lane change parameter, i.e.
lane_change_prepare_duration.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.