fix(aws-appsync) #342
Closed
fix(aws-appsync) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If auto-reconnect when coming back online is needed, users should use `client.sync` (deltaSync) instead.
add promised version as valid types for CredentialsGetter - see awslabs#264
Parity with @aws-amplify/api on graphql package dependency
There was a problem hiding this comment.
Can we review this to avoid duplicate packages?
~ yarn && yarn bootstrap && yarn list --pattern apollo
yarn list v1.7.0
├─ [email protected]
│ ├─ [email protected]
│ └─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
│ └─ [email protected]
└─ [email protected]
…ning (awslabs#347) Fixes awslabs#354 This fixes an InvalidSignatureExceptions that occurs when using iamBasedAuthentication and the '@@controlEvents' variable in subscriptions
I can't find anywhere in the console that I can download a file named AppSync.js... but I have aws-exports.js. The docs are still very confusing when new to all of these libraries that can be mixed and matched. I can get the Amplify CLI to work out of the box, but as soon as you try to add AWSAppSyncClient instead and use the Apollo client things get very confusing to me.
…n options (awslabs#401) * fix(deltaSync): Read last sync timestamps from store if not present in options * Remove expensive logging
* Relicensing to Apache 2.0 * Updating package.json license fields
* update jest To include fix for: jestjs/jest#6730 * Remove noEmitOnError from tsconfig * Remove unneeded mock * Fix test Not sure why, but jest seems to have trouble loading some modules, the filter(Boolean) makes the test pass * Dedupe packages * Accept keyPrefix in config to allow per client storage in multi-client * Pass keyPrefix when creating store * Typescript fixes * Add colon to keyPrefix in store * Remove unused import * Return false instead of undefined when response is not optimistic * Enforce unique keyPrefixes among clients Unit tests refactoring to account for module state (keyPrefixesInUse) * Improve typings for auth options * Make invalid auth type error non retryable * Add test coverage for AWS_IAM auth mode * Kepp client instances around to prevent garbage collection * Use default prefixKey from redux-persist
It seems like the keys `aws-exports.js` have changed since writing the tutorial.
Passing an undefined to the path parameter of getValueByPath results in an error. This change fixes that issues by setting the default value of the path param to be an empty array.
… whose result does not contain a list (awslabs#455)
BREAKING CHANGE: This change adds support for React Native 0.60 but may not be compatible with RN < 0.59 * fix: Add support for React Native 0.60 * Updating package.json * Updating yarn.lock
Adding instructions for using the library with React Native >= 0.60 after the 2.00 release
Adding `aws-appsync-auth-link` and `aws-appsync-subscription-link` packages
* Link usage update
|
Hello @elorzafe @manueliglesias , My company just released an app into production using the AppSync client and we were experiencing really bad memory issues/leaks. We were able to track it down to calling a mutation with an optimistic response which sometimes causes a +200MB increase in memory usage which never drops down to what it previously baselined at. After making a few mutations, the app eventually crashes. We came across this issue which then led us to this issue. We tested mutations with and without optimistic responses and can definitely confirm that this is the cause of our memory problem. All of that to say that merging this PR in would really help us or anyone that plans on using this client long-term. Thanks! |
|
Running locally, fresh git clone, I am not seeing duplicates. @haverchuck can you fix the conflicts for the package.json and the yarn.lock and push the update for it? |
|
@ChrisFieldsII @manueliglesias @sammartinez This is an old PRs and it looks like there are some rebasing issues... I'm going to reopen a new one off of master. |
|
Sounds @haverchuck thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#334
Description of changes:
Updates apollo-cache-inmemory in accordance with this discussion (pointed out by customer).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.