Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deleting single timesheet entries before submit. #35 #41

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Handle deleting single timesheet entries before submit. #35 #41

merged 4 commits into from
Oct 24, 2022

Conversation

syedfkabir
Copy link
Contributor

@syedfkabir syedfkabir commented Oct 20, 2022 •
edited
Loading

Resolves #35

Changes

  • added a new HTTP method DELETE to /entry/controller/item.ts
  • added a new Entry service called deleteEntry()
  • invalidating the entry collection upon deletion

@syedfkabir syedfkabir marked this pull request as draft October 20, 2022 23:30
@syedfkabir syedfkabir marked this pull request as ready for review October 23, 2022 23:25
evert
evert reviewed Oct 24, 2022
View reviewed changes
src/entry/controller/item.ts Outdated Show resolved Hide resolved
src/entry/controller/item.ts Outdated Show resolved Hide resolved
@syedfkabir syedfkabir requested a review from evert October 24, 2022 16:25
@syedfkabir syedfkabir merged commit d964578 into main Oct 24, 2022
@syedfkabir syedfkabir deleted the sk/35/handle-deleting-single-timesheet branch October 24, 2022 17:48
@BeckyPollard BeckyPollard mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evert evert evert approved these changes

@BeckyPollard BeckyPollard Awaiting requested review from BeckyPollard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle deleting single timesheet entries before submit.
3 participants
@syedfkabir @evert @syedfarhankabir