Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for timesheet entry delete #51

Merged
merged 15 commits into from
Oct 25, 2022
Merged

Conversation

BeckyPollard
Copy link
Contributor

@BeckyPollard BeckyPollard commented Oct 21, 2022

RE: Add UI for deleting content

Summary of changes:

  • Add a button to handle deletion of entry.
  • Add a confirmation prompt before delete, to avoid heartbreaks.
    • Featuring full keyboard accessibility from the accessible modal dialog component package react-modal.
    • Very basic styling on the modal, pending design directions for app.
    • New reusable component for these kinds of action prompts: ConfirmModal ✨
  • Add esModuleInterop to tsconfig.

Relies on:


NEW BUTTON CONFIRM PROMPT
Screen Shot 2022-10-21 at 4 44 55 PM Screen Shot 2022-10-21 at 4 54 22 PM

Feedback, nitpicks, and/or corrections encouraged. 🤖

@BeckyPollard BeckyPollard marked this pull request as ready for review October 21, 2022 20:56
@BeckyPollard BeckyPollard added the enhancement New feature or request label Oct 21, 2022
tsconfig.json Outdated Show resolved Hide resolved
@BeckyPollard BeckyPollard merged commit 30712cc into main Oct 25, 2022
@BeckyPollard BeckyPollard deleted the 45/timesheet-entry-delete-ui branch October 25, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants