Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deleting single timesheet entries before submit. #35

Closed
Tracked by #32
BeckyPollard opened this issue Oct 17, 2022 · 3 comments · Fixed by #41
Closed
Tracked by #32

Handle deleting single timesheet entries before submit. #35

BeckyPollard opened this issue Oct 17, 2022 · 3 comments · Fixed by #41
Assignees
Milestone

Comments

@BeckyPollard
Copy link
Contributor

BeckyPollard commented Oct 17, 2022

Create a new HTTP method, DELETE, on the Entry item controller.

Need to let users delete content they created.

  • Delete timesheet entries.
@evert
Copy link
Collaborator

evert commented Oct 17, 2022

With the exception of being able to delete time-entries (before they are frozen?) i think most of these could probably be done post-mvp?

It's not uncommon for MVP-style applications to require an email to support for more drastic delete operations. They are a little tricky.

@BeckyPollard
Copy link
Contributor Author

i thought just clicking a button to delete/remove a submitted time entry would be basic, but if it's something that is best addressed in a later milestone that's totally cool

@ikbensiep
Copy link

I agree with the issue that it could be useful while developing to delete stuff, in testing the frontend you tend to create a lot of nonsense stuff, it's nice to be able to easily delete all that.

I can see this being ACL-restricted, maybe that's one of evert's concerns?

@BeckyPollard BeckyPollard changed the title Handle deleting content. Handle deleting single timesheet enteries before submit. Oct 18, 2022
@syedfkabir syedfkabir changed the title Handle deleting single timesheet enteries before submit. Handle deleting single timesheet entries before submit. Oct 20, 2022
syedfkabir added a commit that referenced this issue Oct 24, 2022
…imesheet

Handle deleting single timesheet entries before submit. #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants