Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate entry's sheet collection when delete #45

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Invalidate entry's sheet collection when delete #45

merged 3 commits into from
Oct 25, 2022

Conversation

BeckyPollard
Copy link
Contributor

@BeckyPollard BeckyPollard commented Oct 25, 2022 •
edited
Loading

RE: Handle deleting single timesheet entries before submit

Summary of changes:

  • Add invalidates link for the entry delete controller action thing.
    • Why: when deleting an entry, on the frontend the collection items would still maintain the deleted entity as part of the rendered list. Now, the collection updates on delete and the render is correct.

Feedback, nitpicks, and/or corrections encouraged. 🤖

@BeckyPollard BeckyPollard added the bug Something isn't working label Oct 25, 2022
@BeckyPollard BeckyPollard mentioned this pull request Oct 25, 2022
Merged
evert
evert reviewed Oct 25, 2022
View reviewed changes
src/entry/controller/item.ts Outdated Show resolved Hide resolved
@BeckyPollard BeckyPollard merged commit b225fd2 into main Oct 25, 2022
@BeckyPollard BeckyPollard deleted the 45/invalidate-on-delete branch October 25, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evert evert evert approved these changes

@syedfkabir syedfkabir Awaiting requested review from syedfkabir

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeckyPollard @evert