Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mass update operations for jobs to Dashboard #578

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Apr 21, 2022

Adds mass/bulk ("batch" is reserved for a different idea) Discard/Reschedule/Retry buttons to the Dashboard that are operated via checkboxes in each row (and a toggle-all checkbox in the table header).

I spent zero time trying to make the actual database operations efficient, so that would be an area for improvement if there are problems.

Closes #446

Screen Shot 2022-04-25 at 7 20 31 AM

  • Checkboxes and toggle all on/off
  • Batch form buttons and Controller action
  • Convert old individual buttons to UJS links
  • Add "Select everything" checkbox

@bensheldon bensheldon force-pushed the batch_actions branch 5 times, most recently from c67c21a to c55226b Compare April 25, 2022 14:20
@bensheldon bensheldon changed the title WIP: Add batch operations for jobs Add batch operations for jobs to Dashboard Apr 25, 2022
@bensheldon bensheldon marked this pull request as ready for review April 25, 2022 16:56
@bensheldon bensheldon added the enhancement New feature or request label Apr 25, 2022
@bensheldon bensheldon changed the title Add batch operations for jobs to Dashboard Add mass/bulk operations for jobs to Dashboard Apr 25, 2022
@bensheldon bensheldon force-pushed the batch_actions branch 3 times, most recently from ca5fb4c to 3bfcde1 Compare April 25, 2022 20:56
@bensheldon bensheldon changed the title Add mass/bulk operations for jobs to Dashboard Add mass update operations for jobs to Dashboard Apr 25, 2022
@bensheldon bensheldon merged commit 4f884c1 into main Apr 26, 2022
@bensheldon bensheldon deleted the batch_actions branch April 26, 2022 12:44
@bkeepers
Copy link
Contributor

👍 Awesome, love it.

It'd be nice to be able to do it on additional pages of current filter. I like how Gmail does this:

image

@bensheldon
Copy link
Owner Author

@bkeepers whoops, there is an "Apply to all" button but it is not scoped to the filter, and it should be. I just made #583 to yank it till that's fixed.

bkeepers added a commit to bkeepers/good_job that referenced this pull request Apr 29, 2022
* origin/main:
  Release good_job v2.14.1
  Temporarily disable Mass Action "Apply to all" because the action is badly scoped (bensheldon#583)
  Release good_job v2.14.0
  Add mass update operations for jobs to Dashboard (bensheldon#578)
  Track down incompatibility/race condition between JRuby and RSpec mocks in tests (bensheldon#581)
  Release good_job v2.13.2
  Namespaces assets per Rails docs (bensheldon#580)
  Release good_job v2.13.1
  Set up javascript importmaps for Dashboard; refactor Polling (bensheldon#574)
  Use toasts to show notices and alerts (bensheldon#577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow "mass"-actions through Dashboard (e.g. retry all)
2 participants