Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Mass Action "Apply to all" because the action is badly scoped #583

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Apr 26, 2022

This should be scoped to the current filter:

jobs = if params[:all_job_ids]
ActiveJobJob.all

Noted in #578 (comment)

@bensheldon bensheldon merged commit 8034a1a into main Apr 26, 2022
@bensheldon bensheldon deleted the temp-disable-mass-all branch April 26, 2022 16:56
@bensheldon bensheldon added the bug Something isn't working label Apr 26, 2022
bkeepers added a commit to bkeepers/good_job that referenced this pull request Apr 29, 2022
* origin/main:
  Release good_job v2.14.1
  Temporarily disable Mass Action "Apply to all" because the action is badly scoped (bensheldon#583)
  Release good_job v2.14.0
  Add mass update operations for jobs to Dashboard (bensheldon#578)
  Track down incompatibility/race condition between JRuby and RSpec mocks in tests (bensheldon#581)
  Release good_job v2.13.2
  Namespaces assets per Rails docs (bensheldon#580)
  Release good_job v2.13.1
  Set up javascript importmaps for Dashboard; refactor Polling (bensheldon#574)
  Use toasts to show notices and alerts (bensheldon#577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant