Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example post_processing doesn't work in Wasm #11977

Closed
mockersf opened this issue Feb 19, 2024 · 3 comments · Fixed by #12051
Closed

example post_processing doesn't work in Wasm #11977

mockersf opened this issue Feb 19, 2024 · 3 comments · Fixed by #12051
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-Web Specific to web (WASM) builds P-High This is particularly urgent, and deserves immediate attention
Milestone
0.13.1

Comments

@mockersf
Copy link
Member

Bevy version

0.13, since #10812

What you did

Example post_processing doesn't work in Wasm https://bevyengine.org/examples/Shaders/post-processing/

What went wrong

It should display some chromatic distortion. It doesn't.
@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds labels Feb 19, 2024
@mockersf mockersf added this to the 0.13.1 milestone Feb 19, 2024
@BD103
Copy link
Member

BD103 commented Feb 21, 2024

I'm getting a 404 when accessing post_processing.wgsl.meta. That may be the problem.

image

@mockersf
Copy link
Member Author

I'm getting a 404 when accessing post_processing.wgsl.meta. That may be the problem.

Nop, unrelated and expected. 404 on wasm is the "file not found" status which is expected for those meta files

@mockersf
Copy link
Member Author

Actually pretty much all custom shaders don't work on web
https://bevyengine.org/examples/UI%20(User%20Interface)/ui-material/
https://bevyengine.org/examples/Shaders/shader-material-2d/
https://bevyengine.org/examples/Shaders/animate-shader/

@mockersf mockersf added the P-High This is particularly urgent, and deserves immediate attention label Feb 22, 2024
@mockersf mockersf mentioned this issue Feb 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
@mockersf
set pipeline to queued when shader is not yet available (#12051)
c641882 
# Objective

- Fixes #11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried
Waridley pushed a commit to Waridley/bevy that referenced this issue Feb 23, 2024
@mockersf @Waridley
set pipeline to queued when shader is not yet available (bevyengine#1…
0636595 
…2051)

# Objective

- Fixes bevyengine#11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried

(cherry picked from commit c641882)
Waridley pushed a commit to Waridley/bevy that referenced this issue Feb 24, 2024
@mockersf @Waridley
set pipeline to queued when shader is not yet available (bevyengine#1…
d7ec3c6 
…2051)

# Objective

- Fixes bevyengine#11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried

(cherry picked from commit c641882)
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@mockersf @msvbg
set pipeline to queued when shader is not yet available (bevyengine#1…
1188337 
…2051)

# Objective

- Fixes bevyengine#11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@mockersf @msvbg
set pipeline to queued when shader is not yet available (bevyengine#1…
7e967fd 
…2051)

# Objective

- Fixes bevyengine#11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried
mockersf added a commit that referenced this issue Feb 27, 2024
@mockersf
set pipeline to queued when shader is not yet available (#12051)
5bf5d48 
# Objective

- Fixes #11977 - user defined shaders don't work in wasm
- After investigation, it won't work if the shader is not yet available
when compiling the pipeline on all platforms, for example if you load
many assets

## Solution

- Set the pipeline state to queued when it errs waiting for the shader
so that it's retried
@rparrett rparrett mentioned this issue Mar 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-Web Specific to web (WASM) builds P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Milestone
0.13.1
Development

Successfully merging a pull request may close this issue.

set pipeline to queued when shader is not yet available mockersf/bevy
2 participants
@mockersf @BD103