Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitch VOD link in Auto Contribute panel links to wrong place #1493

Closed
LaurenWags opened this issue Oct 10, 2018 · 1 comment · Fixed by brave/brave-core#555
Closed

Twitch VOD link in Auto Contribute panel links to wrong place #1493

LaurenWags opened this issue Oct 10, 2018 · 1 comment · Fixed by brave/brave-core#555
Assignees
@NejcZdovc
Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@LaurenWags
Copy link
Member

Description

Probably due to #1492 - if you click on a VOD link in the Auto Contribute panel you are taken to a link that doesn't exist because VOD info is being displayed.

Steps to Reproduce

  1. Enable rewards if not already enabled.
  2. Navigate to twitch user video page (I used https://www.twitch.tv/adam13531/videos/all)
  3. Play a video
  4. Wait a bit of time, go back to Rewards page
  5. VOD is listed.
  6. Click on VOD link.

Actual result:

Note URL - entire adam13531_vod_3208066722 is inserted instead of just creator name:

https://www.twitch.tv/adam13531_vod_3208066722/videos

screen shot 2018-10-10 at 2 13 21 pm

Expected result:

Should be directed to https://www.twitch.tv/adam13531/videos

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes
  • Does it reproduce on browser-laptop? no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information
@LaurenWags LaurenWags added this to the Releasable builds 0.55.x milestone Oct 10, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 10, 2018
@NejcZdovc NejcZdovc mentioned this issue Oct 10, 2018
Merged
11 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 11, 2018
@NejcZdovc
Adds fetch favicons for rewards
7fe563f 
Resolves brave/brave-browser#968
Resolves brave/brave-browser#1492
Resolves brave/brave-browser#1493
@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 13, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds fetch favicons for rewards (Twitch and Youtube) brave/brave-core
4 participants
@NejcZdovc @srirambv @LaurenWags @GeetaSarvadnya