Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fav icons for twitch #968

Closed
NejcZdovc opened this issue Sep 5, 2018 · 1 comment · Fixed by brave/brave-core#555
Closed

Fav icons for twitch #968

NejcZdovc opened this issue Sep 5, 2018 · 1 comment · Fixed by brave/brave-core#555
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

When you are watching vod's on twitch favicon should be saved for that particular publisher.
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 5, 2018
@NejcZdovc NejcZdovc mentioned this issue Oct 3, 2018
Merged
11 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 3, 2018
@NejcZdovc
Adds fetch favicons for rewards
71b6d61 
Resolves brave/brave-browser#968
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 11, 2018
@NejcZdovc
Adds fetch favicons for rewards
7fe563f 
Resolves brave/brave-browser#968
Resolves brave/brave-browser#1492
Resolves brave/brave-browser#1493
@LaurenWags LaurenWags mentioned this issue Oct 13, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

Verified test plan in brave/brave-core#555
Sometimes favicons doesn't display for twitch videos, issue is already logged for it #1521

image

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds fetch favicons for rewards (Twitch and Youtube) brave/brave-core
4 participants
@NejcZdovc @srirambv @LaurenWags @GeetaSarvadnya