Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 104 to Chromium 105 (uplift to 1.43.x). #14789

Merged
merged 6 commits into from
Aug 26, 2022
Merged

Upgrade from Chromium 104 to Chromium 105 (uplift to 1.43.x). #14789

merged 6 commits into from
Aug 26, 2022

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 24, 2022 •
edited by kjozwiak
Loading

Resolves brave/brave-browser#23800
Uplift from #13946

Resolves brave/brave-browser#24948
Uplift from #14807

Resolves brave/brave-browser#24953
Resolves brave/brave-browser#24931
Uplift from #14814

Resolves brave/brave-browser#24954
Uplift from #14816

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Aug 24, 2022
@mkarolin mkarolin self-assigned this Aug 24, 2022
@mkarolin mkarolin requested a review from a team as a code owner August 24, 2022 02:53
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Aug 24, 2022
mkarolin and others added 6 commits August 24, 2022 22:54
@mkarolin
Merge pull request #13946 from brave/cr105
e9a5fda 
Upgrade from Chromium 104 to Chromium 105.
@cdesouza-chromium @mkarolin
Multiple manifest files for TypeScript libraries
62b7c3c 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/b63af83d7a97fb7f898e9a2a9de4da6f233c9672

commit b63af83d7a97fb7f898e9a2a9de4da6f233c9672
Author: Luciano Pacheco <[email protected]>
Date:   Fri Jul 1 06:59:19 2022 +0000

    [RELAND] TypeScript: Refactor how to refer to manifest

    Use get_target_outputs() to get the manifest generated from
    ts_library().

    NOTE: get_target_outputs() is limited, it can only refer to build
    targets in the same file and that have appeared above its call, this
    required to move some build rules below ts_library().

    This is a preparation to refactor the ts_library() to generate the
    manifest with different name.

    Bug: b:228405091
@mkarolin
Build fixes for Chromium 105 uplift to 1.43.x.
fb209dc
@mkarolin
Merge pull request #14807 from brave/maxk-105.0.5195.52
5e36b6b 
Upgrade from Chromium 105.0.5195.37 to Chromium 105.0.5195.52.
@mkarolin
Merge pull request #14814 from brave/maxk-fix-profile-destroyer-crash
75957a7 
[Cr105 follow up] Fixes crash in ProfileDestroyer.
@mkarolin
Merge pull request #14816 from brave/maxk-fix-shields-favicon
1820753 
[cr105 follow up] Fixes favicon in Shields Panel.
@kjozwiak kjozwiak added this to the 1.43.x - Release milestone Aug 25, 2022
kjozwiak
kjozwiak approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍

@kjozwiak kjozwiak merged commit 47497f2 into 1.43.x Aug 26, 2022
@kjozwiak kjozwiak deleted the cr105-1.43.x branch August 26, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@cdesouza-chromium cdesouza-chromium Awaiting requested review from cdesouza-chromium

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @kjozwiak @cdesouza-chromium