Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C80 - custom tip banners do not display images #8074

Closed
LaurenWags opened this issue Feb 5, 2020 · 4 comments · Fixed by brave/brave-core#4514
Closed

C80 - custom tip banners do not display images #8074

LaurenWags opened this issue Feb 5, 2020 · 4 comments · Fixed by brave/brave-core#4514
Assignees
@mkarolin
Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.3.x - Release

Comments

@LaurenWags
Copy link
Member

Description

Images on custom tip banners do not display in C80 versions of Brave.

Steps to Reproduce

  1. Launch 1.3.110 with clean profile & staging parameters (can use prod as well, doesn't matter)
  2. Navigate to a site with a known custom banner (kjozwiakstaging.github.io on staging works or https://www.youtube.com/user/JJDSampson on prod works)
  3. View custom banner

Actual result:

custom tip banner from 1.3.110 (C80):
Screen Shot 2020-02-05 at 10 50 37 AM

Expected result:

custom tip banner from 1.3.108 (C79):
Screen Shot 2020-02-05 at 10 50 18 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? not on 1.2.43, but yes on 1.3.110
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? yes, reproduces on 1.5.81

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @jsecretan @NejcZdovc @mandar-brave
@LaurenWags LaurenWags added this to the 1.3.x - Release milestone Feb 5, 2020
@LaurenWags LaurenWags changed the title C80 - custom tip banners do not display C80 - custom tip banners do not display images Feb 5, 2020
@LaurenWags
Copy link
Member Author

Reproduced on Nightly

Brave 1.5.81 Chromium: 80.0.3987.78 (Official Build) nightly (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS macOS Version 10.14.6 (Build 18G103)

Using production:
Screen Shot 2020-02-05 at 10 51 35 AM

@mkarolin mkarolin self-assigned this Feb 5, 2020
@mkarolin mkarolin mentioned this issue Feb 5, 2020
Merged
32 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Feb 5, 2020
@mkarolin
Fixes rewards-image handler post C80 bump.
7556666 
The handler now gets a full url instead of just path. In the past the
path was the actual url we wanted retrieved, but now the url includes
the chrome://rewards-image prefix, so we need to extract path from the
url. URLDataSource::URLToRequestPath is used to do that.

Also updated NTP Sponsored Image handler to use
URLDataSource::URLToRequestPath instead of extracting path manually.

Fixes brave/brave-browser#8074
@btlechowski
Copy link

Reproduced on Ubuntu

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS

Reproduced on regular tip and monthly tip

image
image

This was referenced Feb 6, 2020
Merged
Merged
Merged
@srirambv srirambv mentioned this issue Feb 6, 2020
Closed
@rebron
Copy link
Collaborator

rebron commented Feb 7, 2020

Using: macOS Version 1.3.112 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Screen Shot 2020-02-06 at 6 20 19 PM Looking good.

@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2020 •
edited by btlechowski
Loading

Verification passed on

Brave 1.3.112 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.165)
  • Verified custom tip banner is shown correctly
    image

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.3.112 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Production examples:

Screen Shot 2020-02-06 at 11 00 24 PM

Screen Shot 2020-02-06 at 11 00 00 PM

Staging examples:

Screen Shot 2020-02-06 at 11 03 41 PM

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes rewards-image handler post C80 bump. brave/brave-core
6 participants
@kjozwiak @rebron @srirambv @LaurenWags @btlechowski @mkarolin