Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rewards-image handler post C80 bump (1.3.x). #4522

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 6, 2020

Fixes brave/brave-browser#8074
Uplift from #4514

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes rewards-image handler post C80 bump.
@mkarolin mkarolin added this to the 1.3.x - Release milestone Feb 6, 2020
@mkarolin mkarolin self-assigned this Feb 6, 2020
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin requested a review from a team February 6, 2020 06:51
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Both Linux & macOS failed audit-network which is a known issue and not specific to this PR:

macOS failed test-install which is a known issue and not specific to this PR:

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. As per #4522 (comment), audit-network failed on both Linux & macOS and test-install failed on macOS. These are known failures/issues that are not related to this specific PR.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit efc8358 into 1.3.x Feb 6, 2020
@kjozwiak kjozwiak deleted the maxk-fix-rewards-image-1.3.x branch February 6, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants