-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes rewards-image handler post C80 bump. #4514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The handler now gets a full url instead of just path. In the past the path was the actual url we wanted retrieved, but now the url includes the chrome://rewards-image prefix, so we need to extract path from the url. URLDataSource::URLToRequestPath is used to do that. Also updated NTP Sponsored Image handler to use URLDataSource::URLToRequestPath instead of extracting path manually. Fixes brave/brave-browser#8074
be7f832
to
7556666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ntp_sponsored_image_source.cc
LGTM.
Thanks for cleanup! 👍
CI passed (only known |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fixes rewards-image handler post C80 bump.
Fixes rewards-image handler post C80 bump.
Fixes rewards-image handler post C80 bump.
The handler now gets a full url instead of just the path. In the past the
path was the actual url we wanted retrieved, but now the url includes
the
chrome://rewards-image
prefix, so we need to extract path fromthis url.
URLDataSource::URLToRequestPath
is used to do that.Also updated NTP Sponsored Image handler to use
URLDataSource::URLToRequestPath
instead of extracting path manually.Fixes brave/brave-browser#8074
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.