-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign widevine #944
Comments
- #507 - #510 When ready to tackle brave/brave-browser#944, we need to revert this commit (which will only be in 0.55.x branch)
- #507 - #510 When ready to tackle brave/brave-browser#944, we need to revert this commit
Adding changes needed for pipeline in #3981 |
Partially fixed with #3903 and brave/brave-core#2023 ; we'll need #3981 too, as @mihaiplesa called above (then we can close this) |
@bsclifton @mihaiplesa Yay! 👍 |
VMP related PRs are reverted because Windows PR builders failed for signing. |
Verified passed with
Verification PASSED on
Verification passed on
|
@bbondy just a quick double check regarding the case under #944 (comment). When you rename |
Test plan
.sig
file and rename it (ex,.sig.bak
)C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application\version
(Windows admin install)C:\Users\XXX\AppData\Local\BraveSoftware\Brave-Browser-Nightly\Application\version
(Windows non-admin install)/Applications/Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/75.0.68.71/Resources/Brave Browser Nightly Framework.sig
(MacOS)NOTES:
temporarily disabled on macOS with Disable widevine cdm host verification on MacOS #4885 until we solve the problem of theWindows & MacOS works fine.sig
file not working (captured with Widevine VMP follow up #4905).Description
Equivalent to this:
https://github.com/brave/browser-laptop/blob/master/tools/buildInstaller.js#L74
The text was updated successfully, but these errors were encountered: