Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Widevine GN changes until we have a comprehensive PR #513

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Revert Widevine GN changes until we have a comprehensive PR #513

merged 1 commit into from
Sep 27, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 27, 2018 •
edited
Loading

Properly revert the following PRs:

When ready to tackle brave/brave-browser#944, we need to revert this commit

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

n/a

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton
Properly revert the following PRs:
6926ccb 
- #507
- #510

When ready to tackle brave/brave-browser#944, we need to revert this commit
@bsclifton bsclifton self-assigned this Sep 27, 2018
@bsclifton bsclifton changed the title Properly revert the following PRs: Revert Widevine GN changes until we have a comprehensive PR Sep 27, 2018
@bsclifton bsclifton merged commit 8e0bbc0 into master Sep 27, 2018
@bsclifton bsclifton deleted the bsc-revert-widevine-until-its-ready branch September 27, 2018 05:34
bsclifton added a commit that referenced this pull request Sep 27, 2018
@bsclifton
Merge pull request #513 from brave/bsc-revert-widevine-until-its-ready
a096348 
Revert Widevine GN changes until we have a comprehensive PR
@bsclifton
Copy link
Member Author

master 8e0bbc0
0.56.x a096348
0.55.x 21aea58

bsclifton added a commit that referenced this pull request Sep 27, 2018
@bsclifton
Re-implement work done originally done with:
622e34d 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 3, 2018
@bsclifton
Re-implement work done originally done with:
39f8bb5 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 6, 2018
@bsclifton
Re-implement work done originally done with:
d254257 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 11, 2018
@bsclifton
Re-implement work done originally done with:
78ad955 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 14, 2018
@bsclifton
Re-implement work done originally done with:
681d136 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).

This functionality also requires brave/brave-browser#1320
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @bbondy