Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include Widevine Host Verification on official builds #510

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Only include Widevine Host Verification on official builds #510

merged 1 commit into from
Sep 26, 2018

Conversation

bsclifton
Copy link
Member

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

  1. Don't have a file atsrc/third_party/widevine/scripts/signature_generator.py
  2. Run npm run build (not an official build)
  3. Build should succeed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton self-assigned this Sep 26, 2018
ryanml
ryanml approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

@ryanml ryanml merged commit cf79da0 into master Sep 26, 2018
@bsclifton bsclifton deleted the bsc-wv-host-verify-official-only branch September 26, 2018 21:57
ryanml added a commit that referenced this pull request Sep 26, 2018
@ryanml
Merge pull request #510 from brave/bsc-wv-host-verify-official-only
6abdc6e 
Only include Widevine Host Verification on official builds
ryanml added a commit that referenced this pull request Sep 26, 2018
@ryanml
Merge pull request #510 from brave/bsc-wv-host-verify-official-only
753561a 
Only include Widevine Host Verification on official builds
@ryanml
Copy link
Contributor

ryanml commented Sep 26, 2018

master: cf79da0
0.55.x: 6abdc6e
0.56.x: 753561a

@darkdh
Copy link
Member

darkdh commented Sep 26, 2018

@bbondy @bsclifton we should really control enable_cdm_host_verification from brave-browser by override the value or passing the new arg to control it.
Because developers often need to build Release build and we can't expect them to have signing script

@bsclifton
Copy link
Member Author

@darkdh doh - I think that was a miss on my part. Folks building release will have official_build set to true?

@darkdh darkdh mentioned this pull request Sep 26, 2018
Closed
@darkdh
Copy link
Member

darkdh commented Sep 27, 2018

yea, see https://github.com/brave/brave-browser/blob/5d9002808ad37a26f12e453c2d615985d8f8c50a/lib/config.js#L246

bsclifton added a commit that referenced this pull request Sep 27, 2018
@bsclifton
Properly revert the following PRs only from 0.55.x:
21aea58 
- #507
- #510

When ready to tackle brave/brave-browser#944, we need to revert this commit (which will only be in 0.55.x branch)
bsclifton added a commit that referenced this pull request Sep 27, 2018
@bsclifton
Properly revert the following PRs:
6926ccb 
- #507
- #510

When ready to tackle brave/brave-browser#944, we need to revert this commit
@bsclifton bsclifton mentioned this pull request Sep 27, 2018
Merged
11 tasks
bsclifton added a commit that referenced this pull request Sep 27, 2018
@bsclifton
Re-implement work done originally done with:
622e34d 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 3, 2018
@bsclifton
Re-implement work done originally done with:
39f8bb5 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 6, 2018
@bsclifton
Re-implement work done originally done with:
d254257 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 11, 2018
@bsclifton
Re-implement work done originally done with:
78ad955 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).
bsclifton added a commit that referenced this pull request Oct 14, 2018
@bsclifton
Re-implement work done originally done with:
681d136 
- #507
- #510

This code was backed out with #513 (so we can do 0.55.x and 0.56.x builds in the meantime).

This functionality also requires brave/brave-browser#1320
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
cezaraugusto added a commit that referenced this pull request Jul 17, 2019
@cezaraugusto
Imported from brave-ui: Merge pull request #510 from brave/shields-ad…
5649d80 
…v-view

add multiple views for shields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@mbacchi mbacchi Awaiting requested review from mbacchi

@darkdh darkdh Awaiting requested review from darkdh

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@bsclifton @ryanml @darkdh @bbondy