add npm command for running a network audit #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
force-pushed
the
feature/network-audit
branch
from
75f97ea
to
4beddcc
Compare
18 tasks
'npm run network-audit' produces a JSON file, network-audit-results.json, which contains the URL requests and 307's in the current build. it exits with non-zero status if any of the URLs in the audit are not whitelisted
diracdeltas
force-pushed
the
feature/network-audit
branch
from
224b937
to
544d984
Compare
bbondy
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Works great, I posted an issue for devops to get this in CI:
https://github.com/brave/devops/issues/343
bbondy
added a commit
that referenced
this pull request
Oct 18, 2018
add npm command for running a network audit
bbondy
added a commit
that referenced
this pull request
Oct 18, 2018
add npm command for running a network audit
bbondy
added a commit
that referenced
this pull request
Oct 18, 2018
add npm command for running a network audit
This was referenced Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'npm run network-audit' runs the browser with a clean profile for 2 minutes or until the browser quits. it returns non-zero if any of the URL requests that happened within that time aren't whitelisted and prints the failures to stdout.
it also produces a JSON file, network-audit-results.json, which contains all the network requests from the audit and produces a raw JSON file network_log.json which can be loaded in chrome://net-internals
whenever CI is ready, we should run
npm run test-securityautomatically with each PR to check for unexpected network requests and known vulns in dependenciesfix #1694
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: