Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Rounded Corners]: Fix WebContents shadow in light mode (#25738) #25880

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Oct 8, 2024

This reverts commit 74b1dfa.

Resolves brave/brave-browser#41465
Resolves brave/brave-browser#41471

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iefremov iefremov requested a review from a team as a code owner October 8, 2024 14:01
@kjozwiak kjozwiak self-requested a review October 8, 2024 18:45
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force merging 👍 As discussed via Slack, the presubmit failure related to formatting are not blocking. We need to get this reverted and kick off a new Nightly as this could be the culprit that's causing the crashes that @srirambv and @thypon are running into.

@kjozwiak kjozwiak merged commit 6b7124e into master Oct 8, 2024
14 of 20 checks passed
@kjozwiak kjozwiak deleted the ie_revert_corners branch October 8, 2024 18:48
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 8, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.72

fallaciousreasoning added a commit that referenced this pull request Oct 10, 2024
…h fixes (#25895)

* Reapply "[Rounded Corners]: Fix WebContents shadow in light mode (#25738) (#25880)

This reverts commit 6b7124e.

* [Vertical Tabs]: Fix crash caused by uninitialized pref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when launching Browser Crash Report
4 participants