Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds delays for suggestion api (uplift to 1.4) #4436

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Adds delays for suggestion api (uplift to 1.4) #4436

merged 1 commit into from
Jan 29, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 27, 2020 •
edited
Loading

Uplift of #4372
Fixes brave/brave-browser#7709
Fixes brave/brave-browser#6940

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #4372 from brave/ac-delay
a4987c3 
Adds delays for suggestion api
@bsclifton bsclifton added this to the 1.4.x - Dev milestone Jan 27, 2020
@bsclifton bsclifton requested a review from a team January 27, 2020 17:18
@bsclifton bsclifton self-assigned this Jan 27, 2020
@bsclifton bsclifton changed the title Merge pull request #4372 from brave/ac-delay Adds delays for suggestion api (uplift to 1.4) Jan 27, 2020
@kjozwiak
Copy link
Member

Restarting Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/suggestion-api-1.4/1/execution/node/478/log/ failing. It's a known intermittent issue that's not specific to this PR but I need to restart on macOS and Win x64 so might as well restart Linux.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/suggestion-api-1.4/1/execution/node/743/log/ failing.

Restarting Win x64 due to https://ci.brave.com/job/brave-browser-build-pr/job/suggestion-api-1.4/1/execution/node/570/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS Uplift/Blocked labels Jan 27, 2020
@kjozwiak
Copy link
Member

Waiting for the 1.3.x PR before we start uplifting this one. @bsclifton let me know you would prefer merging this rather than waiting for the 1.3.x PR.

kjozwiak
kjozwiak approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Travis & CI/Jenkins passed without any issues. PR was also checked on Nightly by @NejcZdovc and @LaurenWags as per #4372 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit f167d65 into 1.4.x Jan 29, 2020
@kjozwiak kjozwiak deleted the suggestion-api-1.4 branch January 29, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bsclifton bsclifton

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS Uplift/Blocked
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @kjozwiak @kylehickinson