-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds delays for suggestion api #4372
Conversation
d0e07b9
to
111c264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS specifics look good.
@NejcZdovc Are these all are going to be removed with DB migration? I assume we can't do much to implement them in its current state?
- (void)updateContributionInfoStepAndCount:(const std::string&)contribution_id step:(const ledger::ContributionStep)step retry_count:(const int32_t)retry_count callback:(ledger::ResultCallback)callback; | ||
- (void)updateContributionInfoContributedAmount:(const std::string&)contribution_id publisher_key:(const std::string&)publisher_key callback:(ledger::ResultCallback)callback; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should stick with Obj-C naming convention here (i.e. retry_count
→ retryCount
), however, if these methods are just going to be deleted with DB migration at a later date its fine to keep them how they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup all of it will be removed with db migration
@@ -157,8 +157,12 @@ bool DatabaseContributionInfoPublishers::InsertOrUpdate( | |||
return false; | |||
} | |||
|
|||
const std::string query = base::StringPrintf( | |||
"INSERT OR REPLACE INTO %s " | |||
const std::string query_delete = base::StringPrintf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temp fix as we can't do db changes in 1.3. Issue that will resolve it in a right way brave/brave-browser#7838
CI failed on windows for test-scripts (https://ci.brave.com/job/brave-browser-build-pr/job/ac-delay/2/execution/node/225/log/), everything else is ok. Restarting windows |
vendor/bat-native-ledger/include/bat/ledger/public/interfaces/ledger.mojom
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_unblinded.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
26eaefb
to
319bb49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Merging as this is all approved and CI is passing 😄 |
Verified using
Additionally, since PR test plan used UGP grants (virtual grants) only as a means of funding the wallet for testing, I ran the following additional scenarios:
B. Using a KYC'd user wallet did:
|
Adds delays for suggestion api
Adds delays for suggestion api
Adds delays for suggestion api
Adds delays for suggestion api
Resolves brave/brave-browser#7709
Resolves brave/brave-browser#6940
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Plan 1:
Plan 2:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.