Fix #12492: Disable idle detection API #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
reviewed
Nov 4, 2020
app/brave_main_delegate.cc
Outdated
| @@ -236,6 +236,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) { | |||
| network_time::kNetworkTimeServiceQuerying.name, | |||
| password_manager::features::kPasswordCheck.name, | |||
| safe_browsing::kEnhancedProtection.name, | |||
| features::kIdleDetection.name, | |||
mkarolin
reviewed
Nov 4, 2020
| @@ -75,6 +75,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) { | |||
| &network_time::kNetworkTimeServiceQuerying, | |||
| &password_manager::features::kPasswordCheck, | |||
| &safe_browsing::kEnhancedProtection, | |||
| &features::kIdleDetection, | |||
jumde
force-pushed
the
idle_detection
branch
2 times, most recently
from
c1bad8e
to
2b84db3
Compare
|
|
mkarolin
pushed a commit
that referenced
this pull request
Nov 7, 2020
Fix #12492: Disable idle detection API
33 tasks
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12492
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.