Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor widevinePanel.js and widevineInfo.js #8032

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Refactor widevinePanel.js and widevineInfo.js #8032

merged 1 commit into from
Apr 17, 2017

Commits on Apr 16, 2017

  1. Refactor widevinePanel.js and widevineInfo.js

    Closes #8028
    Addresses #7989
    
    - Removed isClickDismiss from the dialog
      Installing Widevine influences globally, not specific to a tab which opens the page which requires Widevine. Removing isClickDismiss would clarify to the users that the third party software which we discourage from using is going to be installed on the browser right now.
    
    - Applied commonForm.js to them in order to make styling consistent
    - Added CommonFormLarge to commonForm.js
    - Added globalStyles.dialogWidth and globalStyles.LargeWidth to global.js
    - Added noMargin and noPadding to commonStyles.js
    - Added margin-top to the bottom text block on widevineInfo.js
    - Added testIds to the buttons and the dialog, modifying dialog.js
      - data-test-id as testId
      - data-test2-id as test2Id
    - Added widevinePanelDialog as a testId
    - Set cursor:pointer
    
    Auditors:
    
    Test Plan:
    1. Visit netflix.com
    2. Click outside of the dialog
    3. Make sure the dialog is not closed
    4. Click "Install and Allow"
    5. Log in to the account
    6. Make sure movies can be played
    Suguru Hirahara committed Apr 16, 2017
    Configuration menu
    Copy the full SHA
    78e5c15 View commit details
    Browse the repository at this point in the history