Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tool-cache is not working #504

Closed
fsvalim opened this issue Mar 21, 2024 · 3 comments · Fixed by #533 or #523
Closed

The tool-cache is not working #504

fsvalim opened this issue Mar 21, 2024 · 3 comments · Fixed by #533 or #523
Labels
bug Something isn't working

Comments

@fsvalim
Copy link

fsvalim commented Mar 21, 2024

Caching is not functioning properly, as each step of the Chromium installation process requires a fresh download instead of utilizing the local version.

image

Part of workflow for reference

      - name: Install Google Chrome
        uses: browser-actions/setup-chrome@v1
        with:
          chrome-version: 120        
          
      - name: Check Google Chrome Version
        run: chrome --version          


      - name: Install Google Chrome
        uses: browser-actions/setup-chrome@v1
        with:
          chrome-version: 120      

      - name: Check Google Chrome Version
        run: chrome --version
@joaopedrocg27
Copy link

Hey, facing this issue on our Isolated GH instance. We need to have the action look for the file locally in the runner and it is not working. It saves the files in the correct location but then it downloads every-time, instead of looking for them.

What we are using: https://docs.github.com/en/[email protected]/admin/github-actions/managing-access-to-actions-from-githubcom/setting-up-the-tool-cache-on-self-hosted-runners-without-internet-access

@nunosousa-dev
Copy link

I'm also facing this issue 👀

@ueokande ueokande added the bug Something isn't working label Apr 21, 2024
@ueokande
Copy link
Collaborator

ueokande commented May 3, 2024

Thank you for your bug report. The cache with the version in non-server format does not work in tool-cache. This is reported by the following issue:
actions/toolkit#709

We are going to fix this issue in the next version.

ueokande added a commit that referenced this issue May 3, 2024
The tool-cache package does not work for the Chromium version. It works
only for the server format. The chrome has a four-part version like
`120.0.6099.109`, and the tool-cache does not retrieve the cached
version. This pull request replaces the standard tool-cache package with
the cache that supports the chrome version format, four-part, release
channel name, snapshot number, and `latest`.

Close #504
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
…anches--master--components--setup-chrome

🤖 I have created a release *beep* *boop*
---


##
[1.0.0](setup-chrome-v1.7.1...setup-chrome-v1.0.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))


### Miscellaneous Chores

* use v1
([408c365](408c365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](setup-chrome-v1.0.0...setup-chrome-v1.1.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](setup-chrome-v1.1.0...setup-chrome-v1.2.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](setup-chrome-v1.2.0...setup-chrome-v1.3.0)
(2024-07-13)


### Features

* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* sign tag
([37738b1](37738b1))
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants