Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action fails since the last release (1.7.0) #550

Closed
netayg opened this issue May 26, 2024 · 1 comment · Fixed by #551 or #552
Closed

The action fails since the last release (1.7.0) #550

netayg opened this issue May 26, 2024 · 1 comment · Fixed by #551 or #552

Comments

@netayg
Copy link

netayg commented May 26, 2024

Looking at known-good-versions-with-downloads.json file we can see that version 113.0.5672.0 is indeed listed as "good", yet the action fails:

Run browser-actions/setup-chrome@v1
  with:
    chrome-version: 113.0.5672.0
    install-dependencies: false
    install-chromedriver: false
    no-sudo: false
Setup chrome 113.0.5672.0
Attempting to download chrome 113.0.5672.0...
Error: Version 113.0.5672.0 not found in known good versions

This happens since the last setup-chrome release (v1.7.0)

@netayg netayg changed the title The action fails since the last release (1.70) The action fails since the last release (1.7.0) May 26, 2024
@ueokande
Copy link
Collaborator

Thanks for your report. The setup-chrome v1.7.0 supports installing ChromeDriver. It chooses the version which includes both the browser and chrome driver download URL (#548) when you specify the version number. The action throws the error If the specified version does not includes both. I think the action should install the version 113.0.5672.0 if the user doesn't require ChromeDriver.

Please pick up a version which includes both chrome and chromedriver from the known-good-versions-with-downloads.json file or please use the previous version (v1.6.2) as a workaround until we fix the issue.

ueokande added a commit that referenced this issue May 27, 2024
…Driver (#551)

Installing ChromeDriver
(#548) resolves a
version which includes both the Chrome browser and ChromeDriver download
URLs from
[known-good-versions-with-downloads.json](https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json).
Before this change, user was able to install a version which includes
only chrome download URL. The action should be able to download chrome
browser if the user does specifies "install-chromedriver: false" and
matched version does not include ChromeDriver. This PR enables to
install browser if the version does not include ChromeDriver on
"install-chromedriver: false".

Close #550
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
…anches--master--components--setup-chrome

🤖 I have created a release *beep* *boop*
---


##
[1.0.0](setup-chrome-v1.7.1...setup-chrome-v1.0.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))


### Miscellaneous Chores

* use v1
([408c365](408c365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](setup-chrome-v1.0.0...setup-chrome-v1.1.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](setup-chrome-v1.1.0...setup-chrome-v1.2.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this issue Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](setup-chrome-v1.2.0...setup-chrome-v1.3.0)
(2024-07-13)


### Features

* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* sign tag
([37738b1](37738b1))
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants