Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add install-dependencies parameter #521

Merged
merged 9 commits into from
Apr 21, 2024
Merged

feat: Add install-dependencies parameter #521

merged 9 commits into from
Apr 21, 2024

Conversation

ueokande
Copy link
Collaborator

A new parameter install-dependencies is added to the action. The action will install the dependencies if the parameter is set to true on the Linux. It would be useful when you use the action on the self-hosted runner and want to install the dependencies automatically. This feature works only on the Linux runner, otherwise, it will be ignored.

steps:
  - uses: browser-actions/setup-chrome@v1
    with:
      chrome-version: 120
      install-dependencies: true

Close #372

@ueokande ueokande merged commit 808262a into master Apr 21, 2024
32 checks passed
@ueokande ueokande deleted the install-dependencies branch April 21, 2024 05:50
This was referenced Apr 21, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request May 4, 2024
Merged
lucetre
lucetre reviewed May 13, 2024
View reviewed changes
src/dependencies.ts
throw new Error(`Unsupported OS: ${osReleaseId}`);
})();

await pkg.install(packages);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add sudo options here? Currently, we are getting Permission denied when apt-get update.

https://github.com/browser-actions/actions-swing/blob/1fb57b2dfdce6c0f1e3c15af0af169b63d989004/src/pkg/types.ts#L1-L3

image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting Permission denied when apt-get update.
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report. I'm going to manage this issue at #544 (comment)

This was referenced May 14, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this pull request Jul 13, 2024
@github-actions
chore(master): Merge pull request #2 from ueokande/release-please--br…
badecbc 
…anches--master--components--setup-chrome

🤖 I have created a release *beep* *boop*
---


##
[1.0.0](setup-chrome-v1.7.1...setup-chrome-v1.0.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))


### Miscellaneous Chores

* use v1
([408c365](408c365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this pull request Jul 13, 2024
@github-actions
chore(master): release setup-chrome 1.1.0 (#4)
eef2d23 
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](setup-chrome-v1.0.0...setup-chrome-v1.1.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* Output version
([browser-actions#319](https://github.com/ueokande/setup-chrome-sandbox/issues/319))
([01ba6fc](01ba6fc))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* bump typescript from 4.3.2 to 4.9.5
([browser-actions#314](https://github.com/ueokande/setup-chrome-sandbox/issues/314))
([a5f9494](a5f9494))
* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))
* use new set-output
([browser-actions#310](https://github.com/ueokande/setup-chrome-sandbox/issues/310))
([dfa9d49](dfa9d49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this pull request Jul 13, 2024
@github-actions
chore(master): release setup-chrome 1.2.0 (#5)
ffb84c3 
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](setup-chrome-v1.1.0...setup-chrome-v1.2.0)
(2024-07-13)


### Features

* Add `chrome-path` output
([browser-actions#327](https://github.com/ueokande/setup-chrome-sandbox/issues/327))
([b216760](b216760))
* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ueokande pushed a commit to ueokande/setup-chrome-sandbox that referenced this pull request Jul 13, 2024
@github-actions
chore(master): release setup-chrome 1.3.0 (#6)
8a8b5ae 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](setup-chrome-v1.2.0...setup-chrome-v1.3.0)
(2024-07-13)


### Features

* Add `install-dependencies` parameter
([browser-actions#521](https://github.com/ueokande/setup-chrome-sandbox/issues/521))
([808262a](808262a))
* support `macos-14` runner
([browser-actions#483](https://github.com/ueokande/setup-chrome-sandbox/issues/483))
([c7a9638](c7a9638))
* support installing a compatible version of ChromeDriver
([browser-actions#548](https://github.com/ueokande/setup-chrome-sandbox/issues/548))
([f0f75ba](f0f75ba))
* support M1/M2 mac
([browser-actions#426](https://github.com/ueokande/setup-chrome-sandbox/issues/426))
([8a8f449](8a8f449))
* Support to install by a specific version
([browser-actions#444](https://github.com/ueokande/setup-chrome-sandbox/issues/444))
([775b8fb](775b8fb))


### Bug Fixes

* **deps:** bump @actions/io from 1.1.2 to 1.1.3
([browser-actions#333](https://github.com/ueokande/setup-chrome-sandbox/issues/333))
([619ab4e](619ab4e))
* **deps:** bump the actions group with 1 update
([browser-actions#406](https://github.com/ueokande/setup-chrome-sandbox/issues/406))
([f318cc2](f318cc2))
* **deps:** bump the actions group with 1 update
([browser-actions#505](https://github.com/ueokande/setup-chrome-sandbox/issues/505))
([21a0849](21a0849))
* **deps:** bump the actions group with 2 updates
([browser-actions#388](https://github.com/ueokande/setup-chrome-sandbox/issues/388))
([17715dd](17715dd))
* **deps:** migrate a package manager to pnpm
([browser-actions#384](https://github.com/ueokande/setup-chrome-sandbox/issues/384))
([5fa5696](5fa5696))
* fix gpg import
([9f6ed02](9f6ed02))
* fix stable channel version on Intel Mac
([browser-actions#351](https://github.com/ueokande/setup-chrome-sandbox/issues/351))
([68cb47d](68cb47d))
* gpg improt
([c85ed9d](c85ed9d))
* install package with sudo for non-root users by default
([browser-actions#546](https://github.com/ueokande/setup-chrome-sandbox/issues/546))
([5325b7d](5325b7d)),
closes
[browser-actions#544](https://github.com/ueokande/setup-chrome-sandbox/issues/544)
* sign tag
([37738b1](37738b1))
* tool-cache does not work
([browser-actions#533](https://github.com/ueokande/setup-chrome-sandbox/issues/533))
([e88eaf7](e88eaf7)),
closes
[browser-actions#504](https://github.com/ueokande/setup-chrome-sandbox/issues/504)
* try to install browser version when user will not install ChromeDriver
([browser-actions#551](https://github.com/ueokande/setup-chrome-sandbox/issues/551))
([f5596e0](f5596e0)),
closes
[browser-actions#550](https://github.com/ueokande/setup-chrome-sandbox/issues/550)
* Update nodejs version 20
([browser-actions#480](https://github.com/ueokande/setup-chrome-sandbox/issues/480))
([f2d38a6](f2d38a6))
* Update README.md
([64c2529](64c2529))
* Update README.md
([dff232f](dff232f))
* use cached dir on linux
([browser-actions#540](https://github.com/ueokande/setup-chrome-sandbox/issues/540))
([4e11c0b](4e11c0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucetre lucetre lucetre left review comments

@PantelisKatsaros PantelisKatsaros PantelisKatsaros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does this work on Self-hosted runners in Github ?
3 participants
@ueokande @lucetre @PantelisKatsaros