Replace calls to String.format() with concatenation #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
string-format-optimizations
branch
from
93fa252
to
93e3a33
Compare
lemnik
approved these changes
Jun 24, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/SeverityReason.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/FileStore.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/FileStore.java
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
string-format-optimizations
branch
from
0a85e37
to
f0f4830
Compare
fractalwrench
force-pushed
the
string-format-optimizations
branch
from
f0f4830
to
7255d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Replaces calls to
String.formatwith concatenation. This was specifically found to be a problem inDeviceDataCollectorwhich added ~1ms ontoBugsnag.start(), and profiling shows that using concatenation takes ~0.1ms instead.As
String.formatisn't required in most cases throughout the codebase, it has been replaced with concatenation instead.Testing
Relied on existing test coverage.