chore(backport): Backport metrics work (KF-5558) to track/1.22 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add relations endpoints + update manifest to export metrics via service port. There are more rules, but no metrics for them was found. I also cheded alert rules from [2]. The Grafana dashboards will be added to istio-pilot in different PR, since most of metrics used in them are from the istio-pilot. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules.html#rule-istio-1-10 [2]: https://github.com/istio/tools/blob/release-1.14/perf/stability/alertmanager/prometheusrule.yaml
* Add istio control plane dashboard The source of this dashboard is [1]. --- [1]: https://grafana.com/grafana/dashboards/7645-istio-control-plane-dashboard/ * Add aler rule from source [1] based on metrics [2] Found some intteresting alert rules in [1], however based on istio doc [2], only the last one will work, so I added it here. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules#istio [2]: https://istio.io/latest/docs/reference/commands/pilot-discovery/#metrics
rgildein
force-pushed
the
chore/KF-6105/metrics
branch
from
ac4c218
to
7eafe21
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
DnPlas
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting multiple PR at once, but three of them are adding only dashboard and alert rules. Only the #477 is enabling metrics for istio-gateway.
This PR needs to me merged with merge commit instead of squash and merge.