-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-9999 | Add mandatory Copyright + related cleanup #762
CIP-9999 | Add mandatory Copyright + related cleanup #762
Conversation
Do we want to add a |
@Ryun1 you've spotted an interesting problem which I guess had always been a bother & didn't articulate till now. All along, the CIP has had |
... or maybe you mean this CPS header. That was actually one of the things I said should be delayed in the OP, if so... it would be bad if this file itself got omitted on the derived sites due to syntax errors. In any case will double-check all this stuff & update in next few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I meant, do we want to edit the CPS yaml header to have a |
yes & thanks @Ryun1 ... currently it's the same:
|
ahh sorry! I meant also in the template file |
@Ryun1 likewise they are also currently the same in the last section (except for |
Wait, am I being silly? so the header would be:
|
@Ryun1 you are not being silly
p.s. edit: and now I am being silly since I confused the document structure in the CPS with the sample in the Template file. So here I go again with one more commit & thanks again @Ryun1 for the double check 🤓 |
…ion#762) * add mandatory Copyright to CPSs, clean up CIP License glitches * missed License in CPS header * add Copyright section also to CPS template * adding License: tag also to CPS template YAML header
…ion#762) * add mandatory Copyright to CPSs, clean up CIP License glitches * missed License in CPS header * add Copyright section also to CPS template * adding License: tag also to CPS template YAML header
Fixes #759.
In addition to mimicking the CIP licensing requirements for the CPS, this removes static
LICENSE
files from the CIPs that still had them in spite of the fact that linking the license in the document footer is (and is preferred to be) sufficient for license binding. (It also fixes that license link in one case that I missed in #389 "Remediation")It might be less work to do the CPS license updates as part of this PR, but I think not because:
cips.cardano.org
since currently undefined YAML header data might trigger warnings / errors / inappropriate formatting. cc @KtorZ @katomm