Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0001 | Annual overhaul and process update #924

Merged

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Oct 9, 2024

This has all the CIP-0001 pending updates I've collected, resulting from many review threads since the beginning of the year. Most of these points have either been explicitly or tacitly agreed upon already but of course the changes need vigorous review: especially change to Enlistment as per #898.

(updated CIP-0001)


changed document title to CIP Process

set myself as co-author (last on list), based on commit history representing nearly 2 years of maintenance (about half the time CIP-0001 has been followed)

suggest label items for lists in YAML header

update link to #Statuses (invalid on derived sites: cardano-foundation/developer-portal#1335 (comment))

changed Discord invitation link (in references footer) to the same one on the CIP Wiki front page (to try to stop these links from proliferating)

  • also made same change on top level README

added references to the CIP Wiki when appropriate

  • initially: in Motivation, added link to Wiki & definition of its scope vs. the scope of CIP-0001 itself
  • links for key sections, when CIP-0001 also talks about them:
    • beginning of Editors section, since it's a more exhaustive & current list of editors' goals and requirements
    • note at end of "Authors seek feedback" subsection (referring also review checklist)
  • NOT covering the relatively new GitHub state tagging in CIP-0001 since
    • characteristics like Last Check, and state flow in general, were never in CIP-0001 after being removed in the last overhaul;
    • it's a "human element" of the process meant to deal with CIP workflow rather than the CIP itself.

under Versioning

don't include implementation code for the CIP in the CIP directory itself

added new categories, in same "enlisted" section as Plutus and Ledger

rewritten "enlistment" section (#898 (comment)) (cc @zliu41 @lehins @WhatisRT)

  • following @Ryun1's suggestion about keeping the notion of enlistment mainly intact, without eradicating it altogether (Project Enlisting - Rethinking Post-Chang #898 (comment))
  • That whole section is rewritten but preserving the original language whenever possible: though generally "decentralising" it.  Mainly this eliminates the notion that there is a "maintainer" of any enlisted category.
  • I still think the idea of the "enlistment badge" might be useful in "decentralised" enlistment... and probably even more so... so I've left that in.

created section & added Emeritus editors (#901 (comment)) (cc @crptmppt @SebastienGllmt @KtorZ @dcoutts)

  • following EIP-1 here
  • for now have added in same order as appearing as authors in the CIP-0001 header (as opposed to oldest/newest activity OR began/departed OR somehow in order of significance)

CIP-9999 updates:

  • delete its unwanted H1 - an eyesore, especially on derived sites
  • update Implementation Plan item: since the last remaining unticked item never happened & likely never will (though the CPS process has been validated by community usage instead)

Top-level README updates:

  • added Wiki link in header, with invitation to use as pretext for community engagement
  • Communication Channels = out of date & needed to be rewritten (no more YouTube or meeting transcripts; and plenty of activity happens on GitHub without waiting for the biweekly meetings... which we

fixed miscellaneous spelling, white space, formatting and grammar.

changes decided NOT to make:

  • what kind of language to avoid in CIPs (CIP-0119? | Governance Metadata - DReps #788 (comment)): since the crucial question over "point of view" was already addressed in the Wiki here and other breaches of writing style are left to the editors to determine (since mostly these are matters of common sense + imitating other kinds of standards documents)

@rphair rphair added the CIP-0010: new registry entry Adding a new entry to the metadata label registry label Oct 9, 2024
@rphair rphair added Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information and removed CIP-0010: new registry entry Adding a new entry to the metadata label registry labels Oct 9, 2024
@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Oct 9, 2024
CIP-0001/README.md Outdated Show resolved Hide resolved
CIP-0001/README.md Outdated Show resolved Hide resolved
CIP-0001/README.md Outdated Show resolved Hide resolved
CIP-0001/README.md Outdated Show resolved Hide resolved
CIP-0001/README.md Outdated Show resolved Hide resolved
CIP-0001/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! as always Robert
we are lucky to have you

Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of the grammatical issues have been resolved and all of these changes are aligned with the evolving standards that the Editors have addressed throughout the 2024 cycle. LGTM

@rphair
Copy link
Collaborator Author

rphair commented Oct 13, 2024

OK, I'll mark as Last Check & we can merge before meeting if @perturbing has no objections.

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Oct 13, 2024
Copy link
Collaborator

@perturbing perturbing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

CIP-0001/README.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Vellekoop <[email protected]>
@rphair rphair merged commit 9dc0e51 into cardano-foundation:master Oct 14, 2024
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants