Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Expose control over Actions #3794

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Conversation

epage
Copy link
Member

@epage epage commented Jun 6, 2022

This is the derive support for #3774 (see also #3775, #3777)

This combined with value_parser replaces parser. The main
frustration with this is that ArgAction::Count (the replacement for
parse(from_occurrences) must be a u64. We could come up with a
magic attribute that is meant to be the value parser's parsed type. We
could then use TryFrom to convert the parsed type to the user's type
to allow more. That is an exercise for the future. Alternatively, we
have #3792.

Prep for this included

epage added 2 commits June 6, 2022 11:20
This is the derive support for clap-rs#3774 (see also clap-rs#3775, clap-rs#3777)

This combined with `value_parser` replaces `parser`.  The main
frustration with this is that `ArgAction::Count` (the replacement for
`parse(from_occurrences)` must be a `u64`.  We could come up with a
magic attribute that is meant to be the value parser's parsed type.  We
could then use `TryFrom` to convert the parsed type to the user's type
to allow more.  That is an exercise for the future.  Alternatively, we
have clap-rs#3792.

Prep for this included
- clap-rs#3782
- clap-rs#3783
- clap-rs#3786
- clap-rs#3789
- clap-rs#3793
@epage epage merged commit 805cce7 into clap-rs:master Jun 6, 2022
@epage epage deleted the derive branch June 6, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant