This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
added
status - work in progress
regression
Something is broken, but works in previous releases
labels
Sep 3, 2019
Closed
Co-Authored-By: Gabbi Fisher <[email protected]>
Add bucket::upload, bucket::delete
refactor: add kv bucket dir, replace POC code with bucket commands
Add support for generating and initializing site projects
Add asset manifest logic (creation and binding upon worker upload)
Fix asset manifest logic to ensure uploaded files remain on Workers KV remote
Alewis/default site bucket
EverlastingBugstopper
requested review from
adamcf,
a team and
gabbifish
and removed request for
adamcf
September 20, 2019 17:15
EverlastingBugstopper
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :) want to improve error message but there is an issue for that. lets do it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-running feature branch for KV Additions Milestone (https://github.com/cloudflare/wrangler/milestone/10).
Comment-only reviews until WIP removed please.