Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: kv additions #509

Merged
merged 60 commits into from
Sep 20, 2019
Merged

feat: kv additions #509

merged 60 commits into from
Sep 20, 2019

Conversation

ashleymichal
Copy link
Contributor

Long-running feature branch for KV Additions Milestone (https://github.com/cloudflare/wrangler/milestone/10).

Comment-only reviews until WIP removed please.

@ashleymichal ashleymichal added status - work in progress regression Something is broken, but works in previous releases labels Sep 3, 2019
@ashleymichal ashleymichal added this to the 1.4.0 milestone Sep 3, 2019
@ashleymichal ashleymichal self-assigned this Sep 3, 2019
@ashleymichal ashleymichal mentioned this pull request Sep 3, 2019
Closed
ashleymichal and others added 13 commits September 3, 2019 16:16
@ashleymichal
Add bucket::upload, bucket::delete
0ed02e8
@ashleymichal @gabbifish
Apply suggestions from code review
8f79074 
Co-Authored-By: Gabbi Fisher <[email protected]>
@ashleymichal
use failure::bail directly
a144833
@ashleymichal
remove use of ref keyword
4d2190a
@ashleymichal
add bucket commands to docs
7c72229
@ashleymichal
separate parse_directory for upload/delete
63415ea
@ashleymichal
Merge pull request #514 from cloudflare/alewis/add-bucket-operations
22a9ce0 
Add bucket::upload, bucket::delete
@ashleymichal
Merge branch 'feat-kv-commands' into feat-kv-additions
1cff8f3
@ashleymichal
Merge branch 'feat-kv-commands' into feat-kv-additions
e39b993
@ashleymichal
refactor: add kv bucket dir, replace POC code with bucket commands
61419ab
@ashleymichal
cargo clippy; handle file values to kv:key put in main
d744881
@ashleymichal
feedback: tidy bulk delete path error message
c666c42
@ashleymichal
Merge pull request #530 from cloudflare/alewis/refactor-publish-sites
c0d408f 
refactor: add kv bucket dir, replace POC code with bucket commands
@ashleymichal ashleymichal changed the base branch from feat-kv-commands to master September 13, 2019 18:59
ashleymichal and others added 19 commits September 19, 2019 14:39
@ashleymichal
refactor: reorder manifest methods: pub, constructor first
c5d42ad
@ashleymichal
:nailcare: kv:key indentation in main.rs
88ccb0f
@ashleymichal
refactor: pass config_path as argument to Manifest::generate
6518c1d
@ashleymichal
Add --site flag to wrangler generate
2c8ef24
@ashleymichal
Just like all of it
7d4a673
@ashleymichal
cargo clippy
798dfc7
@ashleymichal
code review
5189f8e
@ashleymichal
code review p2
2e489d9
@ashleymichal
code review p3
359b2e8
@ashleymichal
Merge pull request #632 from cloudflare/alewis/build-site
5385c86 
Add support for generating and initializing site projects
@EverlastingBugstopper @gabbifish
Asset Manifest (#629)
12ecc38 
Add asset manifest logic (creation and binding upon worker upload)
@gabbifish
catch oversized files
87d35db
@gabbifish
and i oop (fix bad call to format_err)
0705c87
@ashleymichal
Merge branch 'master' into feat-kv-additions
4768e68
@gabbifish
Ensure that deletion phase of sync also uses keys with value hashes a…
5b7603b 
…ppended
@EverlastingBugstopper
Remove clone of b64_value
cb8a6a8
@ashleygwilliams
Merge pull request #635 from cloudflare/gabbi/fix-asset-manifest-logic
e8bb966 
Fix asset manifest logic to ensure uploaded files remain on Workers KV remote
@ashleymichal
feat #637: add default bucket to generate function
90f321e
@EverlastingBugstopper
Merge pull request #638 from cloudflare/alewis/default-site-bucket
178749a 
Alewis/default site bucket
@EverlastingBugstopper EverlastingBugstopper changed the title [WIP] - feat: kv additions feat: kv additions Sep 20, 2019
@EverlastingBugstopper EverlastingBugstopper requested review from adamcf, a team and gabbifish and removed request for adamcf September 20, 2019 17:15
EverlastingBugstopper
EverlastingBugstopper approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) want to improve error message but there is an issue for that. lets do it

@ashleymichal ashleymichal merged commit b7ff500 into master Sep 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-kv-additions branch September 20, 2019 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

@gabbifish gabbifish Awaiting requested review from gabbifish

Assignees

@ashleymichal ashleymichal

Labels
regression Something is broken, but works in previous releases
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ashleymichal @gabbifish @EverlastingBugstopper @ashleygwilliams