-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcurl: add xp compatibility option #4385
Conversation
@@ -21,7 +21,7 @@ def test(self): | |||
|
|||
if "arm" in self.settings.arch: | |||
self.test_arm() | |||
elif tools.cross_building(self.settings) and self.settings.os == "Windows": | |||
elif tools.cross_building(self.settings) and self.settings.os == "Windows" and self.settings.compiler != "Visual Studio": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little odd, can you please why you changed it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran conan create
, the test phase failed for me, and my thinking was that it's probably due to the fact that I was using the VS compiler with the v141_xp toolset, which I guess will be considered cross compiling from win10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm @uilianries would you have insight on this?
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying libcurl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Some configurations of 'libcurl/7.67.0' failed in build 3 (
|
Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: libcurl/*
conan-center hook activated.
I'm happy to add the option to builds using autotools, but I'm not familiar with it.