Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: add xp compatibility option #4385

Closed
wants to merge 2 commits into from
Closed

libcurl: add xp compatibility option #4385

wants to merge 2 commits into from

Conversation

refactorTractor
Copy link
Contributor

Specify library name and version: libcurl/*

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

I'm happy to add the option to builds using autotools, but I'm not familiar with it.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2021

CLA assistant check
All committers have signed the CLA.

@@ -21,7 +21,7 @@ def test(self):

if "arm" in self.settings.arch:
self.test_arm()
elif tools.cross_building(self.settings) and self.settings.os == "Windows":
elif tools.cross_building(self.settings) and self.settings.os == "Windows" and self.settings.compiler != "Visual Studio":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little odd, can you please why you changed it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran conan create, the test phase failed for me, and my thinking was that it's probably due to the fact that I was using the VS compiler with the v141_xp toolset, which I guess will be considered cross compiling from win10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm @uilianries would you have insight on this?

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Feb 2, 2021

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SSE4 SSE4 closed this Feb 2, 2021
@SSE4 SSE4 reopened this Feb 2, 2021
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libcurl/7.67.0' failed in build 3 (fee7064e06abb3b737dce84c8c9b17ca47c16333):

@conan-center-bot
Copy link
Collaborator

Failure in build 4 (fee7064e06abb3b737dce84c8c9b17ca47c16333):

  • libcurl/7.75.0@:
    An unexpected error happened and has been reported

  • libcurl/7.74.0@:
    All packages built successfully! (All logs)

  • libcurl/7.73.0@:
    An unexpected error happened and has been reported

  • libcurl/7.72.0@:
    An unexpected error happened and has been reported

  • libcurl/7.71.1@:
    Didn't run or was cancelled before finishing

  • libcurl/7.71.0@:
    Didn't run or was cancelled before finishing

  • libcurl/7.70.0@:
    Didn't run or was cancelled before finishing

  • libcurl/7.69.1@:
    Didn't run or was cancelled before finishing

  • libcurl/7.68.0@:
    Didn't run or was cancelled before finishing

  • libcurl/7.67.0@:
    Didn't run or was cancelled before finishing

  • libcurl/7.66.0@:
    Didn't run or was cancelled before finishing

  • libcurl/7.64.1@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Apr 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented May 19, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants