Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcurl: fix MinGW builds + bump dependencies #5356

Merged
merged 9 commits into from
May 1, 2021
Merged

libcurl: fix MinGW builds + bump dependencies #5356

merged 9 commits into from
May 1, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 28, 2021 •
edited
Loading

Specify library name and version: lib/1.0

closes #3475
closes #5355

automake (dragged from libtool) & pkgconf recipes can work together now on Windows since #5329

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 28, 2021 •
edited
Loading

With these modifications:
MinGW builds of libcurl before #5329: https://ci.appveyor.com/project/SpaceIm/conan-libcurl/builds/38871490
MinGW builds of libcurl after #5329: https://ci.appveyor.com/project/SpaceIm/conan-libcurl/builds/38906503

EDIT: shared doesn't seem to work with MinGW for the moment, but it was already broken: #3475

@ghost ghost mentioned this pull request Apr 28, 2021
Closed
@ghost
Copy link

ghost commented Apr 28, 2021 •
edited by ghost
Loading

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm mentioned this pull request Apr 28, 2021
Closed
@ghost ghost mentioned this pull request Apr 28, 2021
Merged
4 tasks
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 28, 2021 •
edited
Loading

I understand what's wrong with MinGW shared build, I'll try to fix it in this PR.

Issues:

  • the patch for MinGW has no effect anymore, because it is applied after the call to autoreconf
  • there are several AC_CHECK_LIB which are too fragile on Windows due to:
    • the naming of zlib in conan recipe
    • LIBS var being cleared if MinGW in the recipe (why??), which can lead to undefined references in AC_CHECK_LIB, silently disabling several features.

@SpaceIm SpaceIm marked this pull request as draft April 28, 2021 12:42
@SpaceIm SpaceIm marked this pull request as ready for review April 28, 2021 15:44
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 28, 2021

It works now: https://ci.appveyor.com/project/SpaceIm/conan-libcurl/builds/38912563

@github-actions github-actions bot mentioned this pull request Apr 28, 2021
Open
@conan-center-bot
Copy link
Collaborator

All green in build 5 (bc066da7ea16feb5c925cad4ba2539e360be4503):

  • libcurl/7.75.0@:
    All packages built successfully! (All logs)

  • libcurl/7.74.0@:
    All packages built successfully! (All logs)

  • libcurl/7.72.0@:
    All packages built successfully! (All logs)

  • libcurl/7.73.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.1@:
    All packages built successfully! (All logs)

  • libcurl/7.71.0@:
    All packages built successfully! (All logs)

  • libcurl/7.69.1@:
    All packages built successfully! (All logs)

  • libcurl/7.70.0@:
    All packages built successfully! (All logs)

  • libcurl/7.68.0@:
    All packages built successfully! (All logs)

  • libcurl/7.67.0@:
    All packages built successfully! (All logs)

  • libcurl/7.66.0@:
    All packages built successfully! (All logs)

  • libcurl/7.64.1@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries April 29, 2021 16:09
@conan-center-bot conan-center-bot merged commit 72e5b27 into conan-io:master May 1, 2021
@SpaceIm SpaceIm deleted the fix/libcurl-mingw branch May 1, 2021 14:43
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
@SpaceIm @AlvaroFS
(conan-io#5356) libcurl: fix MinGW builds + bump dependencies
9c80a12 
* fix build requirements for mingw

* bump dependencies

* use C test_package

* move all patches before specific builds

mingw patch was executed after the call to autoreconf, making it useless

* fix configure checks for MinGW

* remove useless patch for openssl if mingw

* use tool.run_environment() instead of RunEnvironment

* use destination & strip_root in source()

requires conan >= 1.33.0

* executable links fine if mingw & static, but not shared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@madebr madebr madebr approved these changes

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@SpaceIm @conan-center-bot @SSE4 @ericLemanissier @madebr @prince-chrismc