Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: fix darwinssl option #5357

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 28, 2021

Specify library name and version: lib/1.0

closes #441

Perhaps, we should also change darwinssl value to secure-transport in with_ssl recipe option, but it might break consumers.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

with-darwinssl option in configure.ac has been renamed with-secure-transport since 7.64.1
curl/curl@76a9c3c
@ghost
Copy link

ghost commented Apr 28, 2021

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 28, 2021

Actually, it's not really a "fix", with-darwinssl option is still there (for backward compatibility of configure script I guess), but it has the same effect than with-secure-transport option. But only with-secure-transport is documented now.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (7601c64f15c5ef22f05758a905fab31a3a7d1123):

  • libcurl/7.72.0@:
    All packages built successfully! (All logs)

  • libcurl/7.75.0@:
    All packages built successfully! (All logs)

  • libcurl/7.74.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.1@:
    All packages built successfully! (All logs)

  • libcurl/7.73.0@:
    All packages built successfully! (All logs)

  • libcurl/7.70.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.0@:
    All packages built successfully! (All logs)

  • libcurl/7.66.0@:
    All packages built successfully! (All logs)

  • libcurl/7.64.1@:
    All packages built successfully! (All logs)

  • libcurl/7.69.1@:
    All packages built successfully! (All logs)

  • libcurl/7.68.0@:
    All packages built successfully! (All logs)

  • libcurl/7.67.0@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries April 29, 2021 16:08
@@ -230,7 +230,7 @@ def _get_configure_command_args(self):
"--with-libmetalink={}".format(yes_no(self.options.with_libmetalink)),
"--with-libpsl={}".format(yes_no(self.options.with_libpsl)),
"--with-schannel={}".format(yes_no(self.options.with_ssl == "schannel")),
"--with-darwinssl={}".format(yes_no(self.options.with_ssl == "darwinssl")),
"--with-secure-transport={}".format(yes_no(self.options.with_ssl == "darwinssl")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With schannel would this disable TLS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubled checked the other options when I saw this

curl/curl@68d89f2

Removes: --with-winssl, --with-darwinssl and all --without-* options for
TLS libraries

We might have issues on the next release

params.append("--without-wolfssl")

few others that were removed

@conan-center-bot conan-center-bot merged commit a10f21f into conan-io:master May 2, 2021
@SpaceIm SpaceIm deleted the fix/libcurl-secure-transport branch May 2, 2021 20:39
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
with-darwinssl option in configure.ac has been renamed with-secure-transport since 7.64.1
curl/curl@76a9c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] libcurl/all: doesn't seems to support --with-secure-transport on apple systems
5 participants