-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcurl: fix darwinssl option #5357
libcurl: fix darwinssl option #5357
Conversation
with-darwinssl option in configure.ac has been renamed with-secure-transport since 7.64.1 curl/curl@76a9c3c
I detected other pull requests that are modifying libcurl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
b1f9575
to
7601c64
Compare
Actually, it's not really a "fix", with-darwinssl option is still there (for backward compatibility of configure script I guess), but it has the same effect than with-secure-transport option. But only with-secure-transport is documented now. |
All green in build 2 (
|
@@ -230,7 +230,7 @@ def _get_configure_command_args(self): | |||
"--with-libmetalink={}".format(yes_no(self.options.with_libmetalink)), | |||
"--with-libpsl={}".format(yes_no(self.options.with_libpsl)), | |||
"--with-schannel={}".format(yes_no(self.options.with_ssl == "schannel")), | |||
"--with-darwinssl={}".format(yes_no(self.options.with_ssl == "darwinssl")), | |||
"--with-secure-transport={}".format(yes_no(self.options.with_ssl == "darwinssl")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With schannel
would this disable TLS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doubled checked the other options when I saw this
Removes: --with-winssl, --with-darwinssl and all --without-* options for
TLS libraries
We might have issues on the next release
params.append("--without-wolfssl") |
few others that were removed
with-darwinssl option in configure.ac has been renamed with-secure-transport since 7.64.1 curl/curl@76a9c3c
Specify library name and version: lib/1.0
closes #441
Perhaps, we should also change darwinssl value to secure-transport in
with_ssl
recipe option, but it might break consumers.conan-center hook activated.