Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cleaned destination path for indexing image volumes #5222

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Use cleaned destination path for indexing image volumes #5222

merged 1 commit into from
Feb 20, 2020

Commits on Feb 17, 2020

  1. Use cleaned destination path for indexing image volumes 

    We use filepath.Clean() to remove trailing slashes to ensure that
when we supercede image mounts with mounts from --volume and
--mount, paths are consistent when we compare. Unfortunately,
while we used the cleaned path for the destination in the mount,
it was accidentally not used to index the maps that we use to
identify what to supercede, so our comparisons might be thrown
off by trailing slashes and similar.

Fixes containers#5219

Signed-off-by: Matthew Heon <[email protected]>
    @mheon
    mheon committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    40fa7e9 View commit details
    Browse the repository at this point in the history