Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist module accounts from receiving txs #4797

Merged
merged 12 commits into from
Jul 31, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 29, 2019

Fixes: #4795

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

docs/spec/bank/02_keepers.md Outdated Show resolved Hide resolved
@fedekunze fedekunze closed this Jul 29, 2019
@fedekunze fedekunze force-pushed the fedekunze/4795-fix-macc-inv branch from 115d91e to adf6ddd Compare July 29, 2019 18:28
@fedekunze fedekunze reopened this Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4797 into master will increase coverage by 0.03%.
The diff coverage is 94.52%.

@@            Coverage Diff             @@
##           master    #4797      +/-   ##
==========================================
+ Coverage    50.5%   50.54%   +0.03%     
==========================================
  Files         288      288              
  Lines       18518    18596      +78     
==========================================
+ Hits         9353     9399      +46     
- Misses       8480     8506      +26     
- Partials      685      691       +6

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4797 into master will increase coverage by 0.19%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master    #4797      +/-   ##
==========================================
+ Coverage   50.39%   50.59%   +0.19%     
==========================================
  Files         288      288              
  Lines       18520    18546      +26     
==========================================
+ Hits         9334     9384      +50     
+ Misses       8501     8477      -24     
  Partials      685      685

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, but otherwise LGTM

x/bank/handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

x/bank/internal/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/bank/internal/keeper/invariants.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on spec update and similar changes to distribution

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick

x/bank/internal/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ⚡️

@alexanderbez alexanderbez mentioned this pull request Jul 31, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

break the "module-accounts" Invariant
4 participants