v0.36.0-rc2 Cherry Picks #4769
Merged
v0.36.0-rc2 Cherry Picks #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc2/v0.36.0 #4769 +/- ##
==============================================
- Coverage 53.92% 51% -2.93%
==============================================
Files 273 288 +15
Lines 17367 18752 +1385
==============================================
+ Hits 9366 9564 +198
- Misses 7317 8496 +1179
- Partials 684 692 +8 |
alexanderbez
force-pushed
the
bez/cherry-picks
branch
from
9a9ff9b
to
bdf3653
Compare
…nds to a ModuleAcc
* added back the tools targets * removed ci target
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
jackzampolin
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 picks from
mastersince the latest RC1 of v0.36.0Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: