-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.42 #2852
Merged
Merged
Release/1.42 #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: upper case constants * feat: set default number of parts to 2 * fix: when input is empty or < min, set min * chore: run validation onBlur and allow anything to be input * chore: use 0 as placeholder instead of 0.0 * fix: remove limit of max 100 parts, but limits it to 100_000
* feat(twap): pass order class and slippage to app-data * fix: upload twap app-data * chore: update app-data package
…#2777) * feat: add wallet compatibility events * feat: add modify handler analytics * feat: add TWAP with conversion events * feat: add event on advanced order tab click * feat: add fortune cookie events * fix: different origin for cookies * fix: fix useIsFallbackHandlerRequired logic * fix: pr comment * fix: pr comments 2 * fix(twap): wallet compatiblity event * fix(twap): fallback logic check update --------- Co-authored-by: Alexandr Kazachenko <[email protected]>
* feat: add `(incl. fee)` to price label on TWAP review modal * feat: update Price label on TWAP form * chore: add `/slippage` to min received field
* feat: disable review modal confirm button if there's any validation error * feat: re-use TwapFormWarnings inside the confirmation modal * feat: show TwapFormWarnings inside TwapConfirmModal
* feat: use different button text defaults when expert mode or not * feat: limit order confirm button text changed to `Place limit order` * feat: update TWAP confirmation modal button text to `Place TWAP order`
* feat: do not show est. exec. price for twap parent orders * refactor: use getIsComposableCowParentOrder
* feat(twap): add TWAP unlock screen * fix(twap): hide orders table * feat(twap): pr comments * chore(twap): add todo comment
* feat(twap): display order id on receipt for twap part orders * feat: not all part orders exist in the explorer
* fix(twap): hide learn more link * feat: update styles (#2817) * fix(twap): pr comments --------- Co-authored-by: fairlight <[email protected]>
* feat: surplus account styling * feat: surplus account styling * feat: surplus account styling mobile * Fix code style issues with Prettier * feat: surplus account styling mobile * Fix code style issues with Prettier * Update src/modules/account/containers/AccountDetails/SurplusCard.tsx Co-authored-by: Leandro <[email protected]> * Fix code style issues with Prettier * feat: full width card --------- Co-authored-by: Lint Action <[email protected]> Co-authored-by: Leandro <[email protected]>
* feat: add useNeedsZeroApproval * feat: add needsZeroApproval flag to TwapOrderCreationContext * feat: create zero approval tx if needed for TWAP * test: add unit test for zeroApproval tx * refactor: use `0` instead of CurrencyAmount instance * feat: show zero approval and bundle warnings on twap form * refactor: extract showFallbackHandlerWarning boolean * fix: do not show bundle & zero approval warnings on review modal
* fix(twap): fix slippage value crash * fix: dumb rounding, it should be done AFTER multiplying it by 100 🤦 * chore: default to 10 without decimals
* feat: twap form styling WIP * Fix code style issues with Prettier * feat: twap form styling WIP * feat: twap form styling WIP * Fix code style issues with Prettier * feat: twap form styling WIP * feat(twap): refactor and wire price protection (#2797) * refactor: `ReactNode` already has `string` inside it * feat: new optional params to ExecutionPrice * refactor: make TradeWidgetField and TradeNumberInput more generic * feat: calculate limit price and pass it down to price protection row * feat: pass isInverted state onto price row * feat: calculate buyAmount outside of twapOrderAtom * feat: use buyAmount from its own atom twapOrder is null when the account isn't set * feat: show `0` rather than `-` when there's no limit price * chore: fix merge * Fix code style issues with Prettier * Update src/modules/twap/containers/TwapFormWidget/index.tsx Co-authored-by: Leandro <[email protected]> * feat: twap form styling WIP (#2796) * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * feat: twap form styling WIP * Fix code style issues with Prettier * feat: update styles * feat: update styles * feat: update styles * Fix code style issues with Prettier * feat: styling updates * feat: styling updates * feat: styling updates * feat: styling updates * Fix code style issues with Prettier * feat: styling updates * feat: styling updates * feat: fix custom date style * feat: safar text color fix * feat: fix styles * feat: fix styles * feat: fix styles --------- Co-authored-by: Lint Action <[email protected]> * feat: styles update * feat: styles update --------- Co-authored-by: Lint Action <[email protected]> Co-authored-by: Leandro <[email protected]> Co-authored-by: Alexandr Kazachenko <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
* chore: add min received tooltip * chore: add TWAP order details tooltips * chore: add tooltip for limit price * chore: label and tooltips now accept ReactNode * chore: add tooltip for limit price * chore: add tooltips to Safe fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TWAP GOES LIVE
TODO: add notes
Changelog
1db794b Merge branch 'main' into develop
c47b5c4 Merge branch 'main' into develop
57f11c9 Merge branch 'release/1.41.0' into develop
4ff7db7 feat: wrap symbol name surplus modal (#2842)
27d6829 WIP > feat: twap form styling WIP (#2785)
f8ebf26 fix(twap): fix slippage value crash (#2835)
941f3b5 Merge branch 'release/1.41.0' into develop
d26f93b Merge branch 'main' into develop
e229787 feat(twap): reset USDT allowance (#2819)
44e48d2 Surplus account styling 1 (#2776)
251f56a fix(twap): hide learn more link (#2815)
b9515d9 feat(twap): display order id on receipt for twap part orders (#2806)
ba6417d fix(surplus-pending-swap-buy-receipt): fix receipt for pending buy swap orders (#2811)
63b2ca8 feat(filled-tooltip): update filled tooltip (#2814)
bd9838b fix(orders-table): display fulfilled status before cancelling (#2770)
dc1c2aa feat(twap): add TWAP unlock screen (#2803)
82d1c67 feat(twap): do not show est. exec. price for twap parent orders (#2804)
cf15971 feat(twap): review button label on limit (#2807)
f6db0e5 feat(twap): disable confirm button when form validation fails (#2805)
58bf46a fix(currencyId): remove unecessary variable
0a54201 feat(twap): update TWAP price labels (#2794)
fab1717 fix: check chainId validity on the lowest app level (#2726)
8c2d3b3 feat(twap): add missing TWAP GA events and some fortune cookie events (#2777)
dcb2d54 fix(twap): total time values dropdown (#2798)
a13101c feat(twap): calculate and display TWAP orders execution info (#2764)
a1d121e refactor(swap): clean up Swap widget from isWrapOrUnwrap (#2775)
f087e38 feat(trade): generalise wrap/unwrap flow for all trade widgets (#2774)
096f729 feat(twap): pass order class and slippage to app-data (#2778)
b683402 fix: display relevant link in Order Submitted modal (#2788)
fe875e1 feat(twap): order defaults (#2685)
10ab4c0 feat(twap): display all TWAP parts in orders table (#2795)
ae31bd9 fix(twap): don't request singleOrders data for just mined orders (#2761)