Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] refactor(tokens): integrate TokenLogo component #3197

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 10, 2023

Summary

image

The new tokens library providers TokenLogo component to display a token logo. The algorithm of the component is described here

In this PR I just replaced legacy CurrencyLogo by TokenLogo.

Affected area:

  • orders table
  • activity list (account modal)
  • tokens table
  • all trading widgets (swap/limit/twap)
  • approve button
  • eth-flow UI
  • unsupported token tooltip content
  • swap/limit/twap confirmation modal

To Test

Please, test everything in #3201

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview Oct 26, 2023 0:38am

🌃 Cosmos ↗︎

@shoom3301 shoom3301 changed the title Refactor/tokens lib wiring 2 [4.2] refactor(tokens): integrate TokenLogo component Oct 10, 2023
@shoom3301 shoom3301 self-assigned this Oct 10, 2023
@@ -163,3 +164,73 @@ export const Overview = styled.div`
}
`};
`

export const SearchInputFormatter = styled(Column)`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved the code from legacy/components/Tokens/styled.ts

@shoom3301 shoom3301 requested a review from a team October 11, 2023 12:23
@shoom3301 shoom3301 marked this pull request as ready for review October 11, 2023 12:23
…protocol/cowswap into refactor/tokens-lib-wiring-2

# Conflicts:
#	apps/cowswap-frontend/src/legacy/components/Tokens/styled.ts
* refactor(tokens): remove Uniswap currency entities usage (#3199)

* refactor(tokens): use new tokens UI and logic by default (#3200)

* fix(tokens): fix e2e tests for tokens updates (#3193)

* refactor(tokens): remove legacy code (#3194)

* fix(tokens): fix tokens list loading state (#3201)
@shoom3301 shoom3301 merged commit 6b81f4a into refactor/tokens-lib-wiring-1 Oct 26, 2023
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@alfetopito alfetopito deleted the refactor/tokens-lib-wiring-2 branch October 26, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants