-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] refactor(tokens): integrate TokenLogo component #3197
Merged
shoom3301
merged 8 commits into
refactor/tokens-lib-wiring-1
from
refactor/tokens-lib-wiring-2
Oct 26, 2023
Merged
[4.2] refactor(tokens): integrate TokenLogo component #3197
shoom3301
merged 8 commits into
refactor/tokens-lib-wiring-1
from
refactor/tokens-lib-wiring-2
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
Refactor/tokens lib wiring 2
[4.2] refactor(tokens): integrate TokenLogo component
Oct 10, 2023
…protocol/cowswap into refactor/tokens-lib-wiring-2
…protocol/cowswap into refactor/tokens-lib-wiring-2
shoom3301
commented
Oct 11, 2023
@@ -163,3 +164,73 @@ export const Overview = styled.div` | |||
} | |||
`}; | |||
` | |||
|
|||
export const SearchInputFormatter = styled(Column)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just moved the code from legacy/components/Tokens/styled.ts
alfetopito
approved these changes
Oct 17, 2023
anxolin
approved these changes
Oct 18, 2023
…protocol/cowswap into refactor/tokens-lib-wiring-2 # Conflicts: # apps/cowswap-frontend/src/legacy/components/Tokens/styled.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new tokens library providers
TokenLogo
component to display a token logo. The algorithm of the component is described hereIn this PR I just replaced legacy
CurrencyLogo
byTokenLogo
.Affected area:
To Test
Please, test everything in #3201