[4.4] refactor(tokens): remove Uniswap currency entities usage #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
…protocol/cowswap into refactor/tokens-lib-wiring-4
…protocol/cowswap into refactor/tokens-lib-wiring-4
alfetopito
approved these changes
Oct 18, 2023
| export function useSafeDeps(deps: unknown[]): unknown[] { | ||
| return deps.map((dep) => { | ||
| if (dep instanceof NativeCurrency) return dep.symbol | ||
| if (dep instanceof Token) return dep.address.toLowerCase() | ||
| if (dep instanceof CurrencyAmount) return dep.toExact() + dep.currency.symbol + dep.currency.isNative | ||
| if (dep instanceof WrappedTokenInfo) return dep.address | ||
| if (dep instanceof CurrencyAmount) return dep.toExact() + dep.currency.symbol + dep.currency.chainId |
There was a problem hiding this comment.
Hmmm, shouldn't we use the address.toLowerCase() here instead of symbol, since symbol is not unique?
There was a problem hiding this comment.
also, dor nativeCurrency, token and currency, dont we need the to compare also the chainId
anxolin
approved these changes
Oct 18, 2023
| export function useSafeDeps(deps: unknown[]): unknown[] { | ||
| return deps.map((dep) => { | ||
| if (dep instanceof NativeCurrency) return dep.symbol | ||
| if (dep instanceof Token) return dep.address.toLowerCase() | ||
| if (dep instanceof CurrencyAmount) return dep.toExact() + dep.currency.symbol + dep.currency.isNative | ||
| if (dep instanceof WrappedTokenInfo) return dep.address | ||
| if (dep instanceof CurrencyAmount) return dep.toExact() + dep.currency.symbol + dep.currency.chainId |
There was a problem hiding this comment.
also, dor nativeCurrency, token and currency, dont we need the to compare also the chainId
…protocol/cowswap into refactor/tokens-lib-wiring-4 # Conflicts: # apps/cowswap-frontend/src/legacy/utils/trade.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of migration from Uniswap entities.
To Test
Please, test everything in #3201