[2] refactor(tokens): clean up token consts and use TokenWithLogo #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…cowswap into refactor/tokens-consts
…cowswap into refactor/tokens-consts
This was referenced Oct 11, 2023
anxolin
approved these changes
Oct 18, 2023
| @@ -2,7 +2,7 @@ | |||
| // + logic for chainId switch to/from xDAI | |||
| import { SupportedChainId } from '@cowprotocol/cow-sdk' | |||
|
|
|||
| import { XDAI_SYMBOL } from './constants' | |||
| import { XDAI_SYMBOL } from '../tokens' | |||
There was a problem hiding this comment.
I found strange that getChainCurrencySymbols is inside a folder called gnosis_chain but accepts any chain as a parameter
There was a problem hiding this comment.
Indeed! Considering the comment in the file beginning it must be an artifact from Uniswap era.
To avoid the scope blowing I prefer to fix it in the another iteration
| return null | ||
| } | ||
|
|
||
| return currency?.address || (currency as { tokenInfo?: { address?: string } })?.tokenInfo?.address || null | ||
| return currency.address |
| typeof params !== 'number' && 'chainId' in params && 'symbol' in params | ||
|
|
||
| /** | ||
| * TODO: Eventually, we should get rid of uniswap entities and use our own |
…cowswap into refactor/tokens-consts # Conflicts: # libs/common-const/src/tokens.ts # libs/common-utils/src/index.ts
* refactor(tokens): remove excessive types and consts (#3196) * refactor(tokens): integrate TokenLogo component (#3197) * refactor(tokens): wire up components to new hooks (#3198) * refactor(tokens): remove Uniswap currency entities usage (#3199) * refactor(tokens): use new tokens UI and logic by default (#3200) * fix(tokens): fix e2e tests for tokens updates (#3193) * refactor(tokens): remove legacy code (#3194) * fix(tokens): fix tokens list loading state (#3201)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
One of our strategic goals is independence from Uniswap legacy.
Currently, we widely use
Currency,NativeCurrency,Token, andCurrencyAmountfrom@uniswap/sdk-core.In the previous PR, I added a new entity
TokenWithLogo. It should replace Currency, NativeCurrency, Token from Uniswap.Currently the migration in the intermediate state, we have to work on it more in the future.
What is changed:
GpEtherandGnosisChainNativeCurrencyare replaced byNATIVE_CURRENCY_BUY_TOKENcurrency.isNative/currency.isTokenis replaced bygetIsNativeToken()currency.wrappedis replaced bygetWrappedToken()libs/common-const/src/tokens.tswas split into several filesPlease, use the new helpers in your next changes.
To Test
Please, test everything in #3201