fix: don't display run passing status if Cloud org is over run limit #26533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 flaky tests on run #45684 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin navigation > #consoleProps > .go() |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
approved these changes
Apr 18, 2023
| @@ -22,7 +22,7 @@ | |||
| v-if="['PASSED', 'OVERLIMIT'].includes(status) || isHidden" | |||
| class="flex flex-col flex-grow w-full p-12 justify-center items-center align-middle " | |||
| > | |||
| <DebugPassed v-if="status === 'PASSED'" /> | |||
| <DebugPassed v-if="status === 'PASSED' && !isHidden" /> | |||
There was a problem hiding this comment.
I tried to take look to find out what constitutes isHidden - looks like this comes from the Cloud, going to assume that this value is correctly calculated (validating it is outside the scope of this repo and PR).
Do you have any context/knowledge of how this is calculated?
Code looks good!
warrensplayer
approved these changes
Apr 19, 2023
| @@ -22,7 +22,7 @@ | |||
| v-if="['PASSED', 'OVERLIMIT'].includes(status) || isHidden" | |||
| class="flex flex-col flex-grow w-full p-12 justify-center items-center align-middle " | |||
| > | |||
| <DebugPassed v-if="status === 'PASSED'" /> | |||
| <DebugPassed v-if="status === 'PASSED' && !isHidden" /> | |||
There was a problem hiding this comment.
You could have switched the order with the DebugOverLimit below and then added a v-else-if="status === 'PASSED'", but this works just fine.
ryanthemanuel
added a commit
that referenced
this pull request
May 1, 2023
Co-authored-by: Matt Henkes <[email protected]> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: Leosvel Pérez Espinosa <[email protected]> Co-authored-by: astone123 <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Lachlan Miller <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Ben M <[email protected]> Co-authored-by: Jordan <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Barthélémy Ledoux <[email protected]> fix: Treat Video compression 0 as false. (#26503) fix: don't display run passing status if Cloud org is over run limit (#26533) fix: unify cdp approach to fix devtools in electron (#26573)
tgriesser
added a commit
that referenced
this pull request
May 3, 2023
* feat/protocol: refactor: migrate from windi to tailwind (#26516) chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472) chore: Update Vite to 4.3.0 (#26553) fix: unify cdp approach to fix devtools in electron (#26573) dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612) chore: update 12.11.0 release date (#26587) chore: 12.11.0 release (#26582) chore: implement experimental ESM stub/spy for Vite (#26536) chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524) chore: add support for Angular 16 (#26052) chore: upgrade Vue to 3.2.47 (#26555) chore: Update v8 snapshot cache (#26537) chore: add missing utm parameters for cloud links to Debug page (#26556) chore: update stalebot to respect new labels and up process rate (#26552) fix: don't display run passing status if Cloud org is over run limit (#26533) chore: update vm2 to 3.9.17 (#26534) feat: display a limit warning on the run navigation component when there are 100 total runs (#26523) chore: Update v8 snapshot cache (#26476) chore: upgrade vm2 (#26495) fix: Treat Video compression 0 as false. (#26503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When a run's results are hidden because the cloud organization is over its test result limit for the month, we shouldn't show the passing state and should only show the "over limit" message on the debug page for that run. Having both messages on screen doesn't look great and could be confusing.
Steps to test
Check out the test that I wrote. Alternatively, spin up a project and record enough runs to go over your free limit on Cypress Cloud. Verify that when you have a passing run selected that is hidden because you are over the limit, that you don't see the passing message of "Well Done! All your tests passed." on screen, and only see the over limit message.
How has the user experience changed?
Before: look at the attached issue
After:
PR Tasks
cypress-documentation?type definitions?